Badger-Vested-Aura contest - 0xDjango's results

Bringing BTC to DeFi

General Information

Platform: Code4rena

Start Date: 15/06/2022

Pot Size: $30,000 USDC

Total HM: 5

Participants: 55

Period: 3 days

Judge: Jack the Pug

Id: 138

League: ETH

BadgerDAO

Findings Distribution

Researcher Performance

Rank: 46/55

Findings: 1

Award: $50.85

🌟 Selected for report: 0

🚀 Solo Findings: 0

Awards

50.8486 USDC - $50.85

Labels

bug
QA (Quality Assurance)
sponsor acknowledged
valid

External Links

[L-01] Remove TODOs

Two to-do's are still visible within the contract.

https://github.com/Badger-Finance/vested-aura/blob/d504684e4f9b56660a9e6c6dfb839dcebac3c174/contracts/MyStrategy.sol#L284 https://github.com/Badger-Finance/vested-aura/blob/d504684e4f9b56660a9e6c6dfb839dcebac3c174/contracts/MyStrategy.sol#L422

[L-02] Lack of event emissions on setters and state-changing functions

The only function that emits an event is the _sendTokenToBribesProcessor() function. All others lack event emissions. Most importantly, setters such as setWithdrawalSafetyCheck(), setProcessLocksOnReinvest(), and setBribesProcessor() should emit emissions to produce an accurate history of their configuration.

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter