Canto Liquidity Mining Protocol - 0xAadi's results

Summary

Low Risk Issues

Non-critical Issues

Low Risk Issues

[L‑01] Missing Event for critical functions or parameters change

Events help non-contract tools to track changes, and events prevent users from being surprised by changes.

There is 4 instance of this issue:

File: contracts/callpaths/LiquidityMiningPath.sol

54:    function claimConcentratedRewards(bytes32 poolIdx, int24 lowerTick, int24 upperTick, uint32[] memory weeksToClaim)

61:    function claimAmbientRewards(bytes32 poolIdx, uint32[] memory weeksToClaim) public payable {

65:    function setConcRewards(bytes32 poolIdx, uint32 weekFrom, uint32 weekTo, uint64 weeklyReward) public payable {

74:    function setAmbRewards(bytes32 poolIdx, uint32 weekFrom, uint32 weekTo, uint64 weeklyReward) public payable {

GitHub: 54, 61, 65, 74

File: contracts/mixins/LiquidityMining.sol

16:     function initTickTracking(bytes32 poolIdx, int24 tick) internal {

24:     function crossTicks(

GitHub: 16, 24

Non-critical Issues

[N‑01] Remove commented codes

There are 2 instances of this issue:

File: contracts/callpaths/LiquidityMiningPath.sol

66:         // require(msg.sender == governance_, "Only callable by governance");

75:         // require(msg.sender == governance_, "Only callable by governance");

GitHub: 66, 75

[N‑02] Follow Solidity standard naming conventions (internal function style rule) for functions

The below codes don’t follow Solidity’s standard naming convention,

internal functions : the mixedCase format starting with an underscore (_mixedCase starting with an underscore)

There are 8 instances of this issue:

File: contracts/mixins/LiquidityMining.sol

16:     function initTickTracking(bytes32 poolIdx, int24 tick) internal {

24:     function crossTicks(

39:     function accrueConcentratedGlobalTimeWeightedLiquidity(

69:     function accrueConcentratedPositionTimeWeightedLiquidity(

156:    function claimConcentratedRewards(

198:    function accrueAmbientGlobalTimeWeightedLiquidity(

224:    function accrueAmbientPositionTimeWeightedLiquidity(

256:    function claimAmbientRewards(

GitHub: 16, 24, 39, 69, 156, 198, 224, 256