Canto Liquidity Mining Protocol - gzeon's results

Lines of code

https://github.com/code-423n4/2023-10-canto/blob/40edbe0c9558b478c84336aaad9b9626e5d99f34/canto_ambient/contracts/mixins/LiquidityMining.sol#L184-L186

Vulnerability details

Impact

The loop the calculate inRangeLiquidityOfPosition might go above tx gas limit when the liquidity position have a large range (i.e. upperTick - lowerTick is huge). The user would not be able to claim reward.

Proof of Concept

https://github.com/code-423n4/2023-10-canto/blob/40edbe0c9558b478c84336aaad9b9626e5d99f34/canto_ambient/contracts/mixins/LiquidityMining.sol#L184-L186

                for (int24 j = lowerTick + 10; j <= upperTick - 10; ++j) {
                    inRangeLiquidityOfPosition += timeWeightedWeeklyPositionInRangeConcLiquidity_[poolIdx][posKey][week][j];
                }

Recommended Mitigation Steps

One solution is to add a function that allow user to pre-calc inRangeLiquidityOfPosition with pagination.

Assessed type

DoS