Notional x Index Coop - 0xSolus's results

Redundant, unnecessary code

Starting in L#596 in the _getFCashPositions(), there's no need to repeat the same loop twice as it's unecessary. Instead, the second loop should be only used to allocate the correct memory space to the fCashPositions variable for only the amount of addresses it's going to store already calculated previously with j.

This is my proposed solution:

    function _getFCashPositions(ISetToken _setToken)
    internal
    view
    returns(address[] memory fCashPositions)
    {
        ISetToken.Position[] memory positions = _setToken.getPositions();
        uint positionsLength = positions.length;
        address[] memory tmp = new address[](positionsLength);
        uint j;

        for(uint256 i = 0; i < positionsLength; i++) {
            // Check that the given position is an equity position
            if(positions[i].unit > 0) {
                address component = positions[i].component;
                if(_isWrappedFCash(component)) {
			tmp[j] = component;
			j++;
                }
            }
        }
	// Write to memory with correct space
	fCashPositions = new address[](j);
        for(uint256 i = 0; i < j; i++) {
		fCashPositions[i] = tmp[i];
	}
    }