Notional x Index Coop - Lambda's results

A collaboration between Notional and Index Coop to create fixed rate yield index tokens.

General Information

Platform: Code4rena

Start Date: 07/06/2022

Pot Size: $75,000 USDC

Total HM: 11

Participants: 77

Period: 7 days

Judge: gzeon

Total Solo HM: 7

Id: 124

League: ETH

Notional

Findings Distribution

Researcher Performance

Rank: 49/77

Findings: 2

Award: $135.56

🌟 Selected for report: 0

🚀 Solo Findings: 0

NotionalTradeModule.sol#L529: A boolean is passed, although the two functions (mintViaUnderlying and mintViaAsset) do not accept a boolean parameter.

In the following places, gas can be saved by caching the length of the array:

  • NotionalTradeModule.sol#L238
  • NotionalTradeModule.sol#L254

Other gas optimizations:

  • wfCashBase.sol: #L84, #L94, #L99: Instead of calculating currencyId and maturity every time, the values could be stored at initialization.
  • wfCashLogic.sol#L305: If tokensTransferred is 0, there will be a transfer with value 0 (costing gas), which could be skipped
  • DateTime.sol#L91: Can be unchecked, already checked for overflow / remainder above.
AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter