The Wildcat Protocol - 0xhegel's results

Lines of code

https://github.com/code-423n4/2023-10-wildcat/blob/c5df665f0bc2ca5df6f06938d66494b11e7bdada/src/market/WildcatMarket.sol?plain=1#L142

Vulnerability details

Impact

There is no way to close a market.

Proof of Concept

1. There is a closeMarket method in WildcatMarket.sol, which is defined can only be called from market controller

2. But in market controller code file WildcatMarketController.sol, there is no code related to close a market by calling 'WildcatMarket.closeMarket'

Tools Used

Manually

Recommended Mitigation Steps

Add related method to WildcatMarketController.sol , for example:

function closeMarket(address market) external onlyBorrower {  
	WildcatMarket(market).closeMarket();  
}

And also update IWildcatMarketController.sol accordingly.

Assessed type

call/delegatecall