The Wildcat Protocol - peter's results

Banking, but worse - a protocol for fixed-rate, undercollateralised credit facilities.

General Information

Platform: Code4rena

Start Date: 16/10/2023

Pot Size: $60,500 USDC

Total HM: 16

Participants: 131

Period: 10 days

Judge: 0xTheC0der

Total Solo HM: 3

Id: 296

League: ETH

Wildcat Protocol

Findings Distribution

Researcher Performance

Rank: 118/131

Findings: 1

Award: $0.06

🌟 Selected for report: 0

🚀 Solo Findings: 0

Lines of code

https://github.com/code-423n4/2023-10-wildcat/blob/c5df665f0bc2ca5df6f06938d66494b11e7bdada/src/market/WildcatMarket.sol#L142

Vulnerability details

Impact

The external "closeMarket()" function in contract "WildcatMarket" has the "onlyController" modifier, which is the controller address that deployed the market. However the controller never invokes the "closeMarket()" function. Therefore external access of this function will always fail.

Proof of Concept

function closeMarket() external onlyController nonReentrant {}

Change "onlyController" modifier in "closeMarket()" function to "onlyBorrower" so that it can be invoked by borrower.

Assessed type

Access Control

#0 - c4-pre-sort

2023-10-27T07:11:04Z

minhquanym marked the issue as duplicate of #147

#1 - c4-judge

2023-11-07T14:01:29Z

MarioPoneder marked the issue as partial-50

#2 - c4-judge

2023-11-07T14:16:53Z

MarioPoneder changed the severity to 3 (High Risk)

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter