Platform: Code4rena
Start Date: 21/08/2023
Pot Size: $36,500 USDC
Total HM: 1
Participants: 43
Period: 7 days
Judge: Dravee
Id: 277
League: ETH
Rank: 39/43
Findings: 1
Award: $9.16
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: Udsen
Also found by: 0xSmartContract, 0xmystery, 0xprinc, Fulum, JP_Courses, MatricksDeCoder, Mirror, MohammedRizwan, MrPotatoMagic, Rolezn, Shubham, Testerbot, ast3ros, chainsnake, lanrebayode77, lsaudit, nisedo, plainshift, pontifex, prapandey031
9.1555 USDC - $9.16
e rather than ** to denote the power of 104 instances https://github.com/code-423n4/2023-08-shell/blob/main/src/proteus/EvolvingProteus.sol#L151 https://github.com/code-423n4/2023-08-shell/blob/main/src/proteus/EvolvingProteus.sol#L181 https://github.com/code-423n4/2023-08-shell/blob/main/src/proteus/EvolvingProteus.sol#L191 https://github.com/code-423n4/2023-08-shell/blob/main/src/proteus/EvolvingProteus.sol#L201
All occurences of MAX_PRICE_VALUE can be replaced with MAX_M. Also all occurences of MIN_PRICE_VALUE can be replaced with MIN_M
https://github.com/code-423n4/2023-08-shell/blob/main/src/proteus/EvolvingProteus.sol#L157a-L175
a<0and b<0The values of a and b has been derived from the function a() and b() from the library LibConfig. These functions uses sqrt() function from ABDKMath64x64 library which never returns negative values hence never let the values of a and b to be negative. This makes the condition a<0 && b<0 redundant.
https://github.com/code-423n4/2023-08-shell/blob/main/src/proteus/EvolvingProteus.sol#L720
#0 - c4-pre-sort
2023-08-30T03:52:04Z
0xRobocop marked the issue as low quality report
#1 - c4-judge
2023-09-11T19:31:00Z
JustDravee marked the issue as grade-b