Shell Protocol - lanrebayode77's results

https://github.com/code-423n4/2023-08-shell/blob/c61cf0e01bada04c3d6055acb81f61955ed600aa/src/proteus/EvolvingProteus.sol#L831

Checking if the absoluteValue is less than FIXED_FEE * 2 should happen inside the block where the deduction will happen, the check is unnecessary if feeUp is true as it will be added to not subtracted from, it is only mandated when subtraction will take place.

        uint256 roundedAbsoluteAmount;
        if (feeUp) {
            roundedAbsoluteAmount =
                absoluteValue +
                (absoluteValue / BASE_FEE) +
                FIXED_FEE;
            require(roundedAbsoluteAmount < INT_MAX);
        } else
            if (absoluteValue < FIXED_FEE * 2) revert AmountError();
            roundedAbsoluteAmount =
                absoluteValue -
                (absoluteValue / BASE_FEE) -
                FIXED_FEE;

        roundedAmount = negative
            ? -int256(roundedAbsoluteAmount)
            : int256(roundedAbsoluteAmount);
    }