Maia DAO Ecosystem - 8olidity's results

Lines of code

https://github.com/code-423n4/2023-05-maia/blob/main/src/talos/base/TalosBaseStrategy.sol#L206-L207 https://github.com/code-423n4/2023-05-maia/blob/main/src/talos/base/TalosBaseStrategy.sol#L144-L145 https://github.com/code-423n4/2023-05-maia/blob/main/src/talos/base/TalosBaseStrategy.sol#L357-L358 https://github.com/code-423n4/2023-05-maia/blob/main/src/talos/TalosStrategyVanilla.sol#L146-L147

Vulnerability details

Impact

There is no slippage protection on any of the calls to increase or decrease liquid-ity, allowing for trades to be subject to MEV-style attacks such as front-running and sandwiching.

The previous audit report mentioned this problem, but only fixed the problem in the redeem() function, but TalosBaseStrategy::init , TalosBaseStrategy::deposit , TalosBaseStrategy::_withdrawAll, TalosStrategyVanilla::_compoundFees These functions are not fixed

Proof of Concept

https://github.com/code-423n4/2023-05-maia/blob/main/src/talos/base/TalosBaseStrategy.sol#L206-L207 https://github.com/code-423n4/2023-05-maia/blob/main/src/talos/base/TalosBaseStrategy.sol#L144-L145 https://github.com/code-423n4/2023-05-maia/blob/main/src/talos/base/TalosBaseStrategy.sol#L357-L358 https://github.com/code-423n4/2023-05-maia/blob/main/src/talos/TalosStrategyVanilla.sol#L146-L147

Tools Used

vscode

Recommended Mitigation Steps

We recommend adding user parameters in that allow for the customization of the level of slippage tolerance so that amount0Min and amount1Min can be adjusted ac-cordingly

Assessed type

Uniswap