Ondo Finance contest - BPZ's results

QA report

FLOATING & OLD VERSION OF PRAGMA

Use debugged complier version . Also use more recent compiler version.

Affected Source Code

Total instances : 19

• OndoPriceOracle.sol:15
• JumpRateModelV2.sol:1
• IOndoPriceOracle.sol:15
• cErc20ModifiedDelegator.sol:7
• cErc20ModifiedDelegator.sol:138
• cErc20ModifiedDelegator.sol:138
• cErc20ModifiedDelegator.sol:181
• cErc20ModifiedDelegator.sol:296
• cErc20ModifiedDelegator.sol:302
• cErc20ModifiedDelegator.sol:324
• cErc20ModifiedDelegator.sol:647
• CTokenModified.sol:2
• CTokenInterfacesModified.sol:2
• CTokenDelegate.sol:2
• CErc20.sol:2
• CTokenCash.sol:2
• CCashDelegate.sol:2
• CCash.sol:2
• Comp.sol:1

LACK OF CHECKS ADDRESS(0)

The following methods have a lack of checks if the received argument is an address, it’s good practice in order to reduce human error to check that the address specified in the constructor or initialize is different than address(0).

Affected Source Code

Total instances : 4

• OndoPriceOracle.sol:80
• OndoPriceOracle.sol:106
• OndoPriceOracle.sol:119
• JumpRateModelV2.sol:64

LACK OF CHEKS FOR UNITS IN ORDER TO PREVENT SETTING DEFAULT VALUES.

In oder to prevent human errors its better to having a value for units rather than inizialize with 0 values.

Total instances : 2

• OndoPriceOracle.sol:80
• JumpRateModelV2.sol:59

Internal and private functions should have an underscore prefix with mixedCase(Naming convention)

Affected Source Code

Total instances : 7

• JumpRateModelV2.sol:171

• cErc20ModifiedDelegator.sol:1200

• CTokenCash.sol:357

• CTokenCash.sol:491

• CTokenCash.sol:1427

• CCash.sol:179

• CCash.sol:193

  For more read...

  1. Soliditydocs

  2. Solidity Style

External & Public Functions should use mixedCase withot underscore

Affected Source Code

Total instances : 32

• cErc20ModifiedDelegator.sol:548

• cErc20ModifiedDelegator.sol:324

• cErc20ModifiedDelegator.sol:548

• cErc20ModifiedDelegator.sol:552

• cErc20ModifiedDelegator.sol:554

• cErc20ModifiedDelegator.sol:558

• cErc20ModifiedDelegator.sol:562

• cErc20ModifiedDelegator.sol:564

• cErc20ModifiedDelegator.sol:602

• cErc20ModifiedDelegator.sol:624

• cErc20ModifiedDelegator.sol:637

• cErc20ModifiedDelegator.sol:642

• cErc20ModifiedDelegator.sol:720

• CTokenInterfacesModified.sol:360

• CTokenInterfacesModified.sol:364

• CTokenInterfacesModified.sol:366

• CTokenInterfacesModified.sol:370

• CTokenInterfacesModified.sol:374

• CTokenInterfacesModified.sol:376

• CTokenInterfacesModified.sol:416

• CTokenInterfacesModified.sol:438

• CTokenInterfacesModified.sol:451

• CTokenInterfacesModified.sol:456

• CTokenDelegate.sol:21

• CTokenDelegate.sol:39

• CErc20.sol:168

• CErc20.sol:236

• CErc20.sol:268

• CCashDelegate.sol:21

• CCashDelegate.sol:39

• CCash.sol:168

• CCash.sol:268

  For more read...

  1. Soliditydocs

Constants should be named with all capital letters with underscores separating words.(For Internal or private constants it should be started with underscore prefix)

Affected Source Code

Total instances : 7

• JumpRateModelV2.sol:29
• cErc20ModifiedDelegator.sol:208
• cErc20ModifiedDelegator.sol:213
• cErc20ModifiedDelegator.sol:350
• CTokenInterfacesModified.sol:33
• CTokenInterfacesModified.sol:36
• CTokenInterfacesModified.sol:113

For more read... 1. Solidity Style

Remove assembly for future updates

its better not to use assembly because it reduce readability & future updatability of the code even though assembly reduce gas.

Recommendation Consider removeing all assembly code and re-implement them in Solidity to make the code significantly more clean.

Total instances : 7

• cErc20ModifiedDelegator.sol:1205
• cErc20ModifiedDelegator.sol:1238
• cErc20ModifiedDelegator.sol:1259
• CErc20.sol:204
• CErc20.sol:244
• CCash.sol:204
• CCash.sol:244

incomplete comments

Total instances : 4

• CTokenDelegate.sol:22
• CTokenDelegate.sol:25
• CCashDelegate.sol:22
• CCashDelegate.sol:25

Unnecessary code(always false)

Total instances : 3

• CTokenDelegate.sol:26
• CCashDelegate.sol:26
• CCashDelegate.sol:41

Modifier and Events should top of the contract(Order of Layout)

• CTokenCash.sol:1434

For more read... https://docs.soliditylang.org/en/v0.8.15/style-guide.html#order-of-layout