Ondo Finance contest - Deekshith99's results

QA Report

[NC-1] Unused imports

There are 2 instance of it & here is the permaliks of it CTokenInterfacesModifiedCash.sol#L7 & CTokenInterfacesModified.sol#L7 it is recommend to remove unused imports for better readability of the code

[NC-2] License type is missing

There are 2 instances of it they are JumpRateModelV2.sol & cErc20ModifiedDelegator.sol Its highly recommend to write the license identifier keyword (license type of the contract) above the version

[NC-3] Use a more recent version of solidity

It is recommend to update the solidity version according some of the contracts are still using older versions and Versions must be consistent with each other.

[NC-4] Stop using v != 27 && v != 28 or v == 27 || v == 28

Here is the permalink of it KYCRegistry.sol#L87 for more refer this link

[NC-5] Can make it more readable

Here is the permalink of it OndoPriceOracleV2.sol#L77 here it can be written as uint256 public maxChainlinkOracleTimeDelay = 90_000; or uint256 public maxChainlinkOracleTimeDelay = 25*60*60;