Golom contest - DevABDee's results

An NFT marketplace that offers the lowest industry fee, a publicly available order-book along with analytical tools.

General Information

Platform: Code4rena

Start Date: 26/07/2022

Pot Size: $75,000 USDC

Total HM: 29

Participants: 179

Period: 6 days

Judge: LSDan

Total Solo HM: 6

Id: 148

League: ETH

Golom

Findings Distribution

Researcher Performance

Rank: 141/179

Findings: 1

Award: $35.17

🌟 Selected for report: 0

🚀 Solo Findings: 0

Require Statements used without Revert Messages

Should input revert err messages in the Require statements. So, when any require statement reverts, it reverts with an error message, so that a failure can more easily be debugged or reacted upon. Or use Custom Errors Instead for better gas optimization & debugging

contracts/vote-escrow/VoteEscrowDelegation.sol 245: require(_isApprovedOrOwner(_sender, _tokenId));

contracts/rewards/RewardDistributor.sol 88: require(msg.sender == trader);
contracts/rewards/RewardDistributor.sol 144: require(epochs[index] < epoch);
contracts/rewards/RewardDistributor.sol 158: require(epochs[index] < epoch);

contracts/core/GolomTrader.sol 220: require(msg.sender == o.reservedAddress);
contracts/core/GolomTrader.sol 285: require(o.totalAmt * amount >(o.exchange.paymentAmt + o.prePayment.paymentAmt + o.refererrAmt) * amount + p.paymentAmt);
contracts/core/GolomTrader.sol 291: require(msg.sender == o.reservedAddress);
contracts/core/GolomTrader.sol 293: require(o.orderType == 1);
contracts/core/GolomTrader.sol 295: require(status == 3);
contracts/core/GolomTrader.sol 296: require(amountRemaining >= amount);
contracts/core/GolomTrader.sol 313: require(o.signer == msg.sender);
contracts/core/GolomTrader.sol 342: require(o.totalAmt >= o.exchange.paymentAmt + o.prePayment.paymentAmt + o.refererrAmt);
contracts/core/GolomTrader.sol 345: require(msg.sender == o.reservedAddress);
contracts/core/GolomTrader.sol 347: require(o.orderType == 2);
contracts/core/GolomTrader.sol 349: require(status == 3);
contracts/core/GolomTrader.sol 350: require(amountRemaining >= amount);

contracts/vote-escrow/VoteEscrowCore.sol 360: require(_entered_state == _not_entered);
contracts/vote-escrow/VoteEscrowCore.sol 540: require(_isApprovedOrOwner(_sender, _tokenId));
contracts/vote-escrow/VoteEscrowCore.sol 646: require(owner != address(0));
contracts/vote-escrow/VoteEscrowCore.sol 648: require(_approved != owner);
contracts/vote-escrow/VoteEscrowCore.sol 652: require(senderIsOwner || senderIsApprovedForAll);
contracts/vote-escrow/VoteEscrowCore.sol 869, 874, 879, 884 & 889: require(msg.sender == voter);
contracts/vote-escrow/VoteEscrowCore.sol 895: require(_from != _to);
contracts/vote-escrow/VoteEscrowCore.sol 927 & 944: require(_value > 0);
AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter