Golom contest - codetilda's results

1. Better to use CONSTANTs rather than 'magic numbers'

There are 11 instances in the scope contracts

#1 GolomToken.sol#L44

https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/contracts/governance/GolomToken.sol#L44

       _mint(_airdrop, 150_000_000 * 1e18);

#2 GolomToken.sol#L52

https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/contracts/governance/GolomToken.sol#L52

       _mint(_rewardDistributor, 62_500_000 * 1e18);

#3 RewardDistributor.sol#L100

https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/contracts/rewards/RewardDistributor.sol#L100

       if (rewardToken.totalSupply() > 1000000000 * 10**18) {

#4 RewardDistributor.sol#L120

https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/contracts/rewards/RewardDistributor.sol#L120

       rewardTrader[epoch] = ((tokenToEmit - stakerReward) * 67) / 100;

#5 RewardDistributor.sol#L121

https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/contracts/rewards/RewardDistributor.sol#L121

       rewardExchange[epoch] = ((tokenToEmit - stakerReward) * 33) / 100;

#6 GolomTrader.sol#L212

https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/contracts/core/GolomTrader.sol#L212

       o.totalAmt >= o.exchange.paymentAmt + o.prePayment.paymentAmt + o.refererrAmt + (o.totalAmt * 50) / 10000,

#7 GolomTrader.sol#L242

https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/contracts/core/GolomTrader.sol#L242

       payEther(((o.totalAmt * 50) / 10000) * amount, address(distributor));

#8 GolomTrader.sol#L252-L260

https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/contracts/core/GolomTrader.sol#L252-L260

        payEther(
            (o.totalAmt -
                (o.totalAmt * 50) /
                10000 -
                o.exchange.paymentAmt -
                o.prePayment.paymentAmt -
                o.refererrAmt) * amount,
            o.signer
        );

#9 GolomTrader.sol#L262-L265

https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/contracts/core/GolomTrader.sol#L262-L265

        payEther(
            (o.totalAmt - (o.totalAmt * 50) / 10000 - o.exchange.paymentAmt - o.prePayment.paymentAmt) * amount,
            o.signer
        );

#10 GolomTrader.sol#L269

https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/contracts/core/GolomTrader.sol#L269

    distributor.addFee([o.signer, o.exchange.paymentAddress], ((o.totalAmt * 50) / 10000) * amount);

#11 GolomTrader.sol#L381

https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/contracts/core/GolomTrader.sol#L381

    uint256 protocolfee = ((o.totalAmt * 50) / 10000) * amount;

---

2. camelCase pattern for CONSTANT declaration

https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/contracts/rewards/RewardDistributor.sol#L48

uint256 constant dailyEmission = 600000 * 10**18;

https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/contracts/rewards/RewardDistributor.sol#L57

uint256 constant secsInDay = 24 * 60 * 60;

---

3. Hardcoded startTime timestamp (guess its misprint)

Hardcoded initial value of startTime state in constructor

RewardDistributor.sol#L84

https://github.com/code-423n4/2022-07-golom/blob/7bbb55fca61e6bae29e57133c1e45806cbb17aa4/contracts/rewards/RewardDistributor.sol#L84

    startTime = 1659211200;

---

NOTE:

• not in scope file Timlock.sol describe Contract Timelock. It looks like misprint in the file name.