Mimo DeFi contest - Funen's results

Non Critical

1. Title : Consistency comment

the top comment line should be the same as the others for better readability, so you can make the lines indent.

##Tool Used Manual Review

##Occurances 1 2

2. Typo Comment

https://github.com/code-423n4/2022-04-mimo/blob/b18670f44d595483df2c0f76d1c57a7bfbfbc083/core/contracts/core/PriceFeed.sol#L41

typo comment oracle It can be changed into oracle

##Tool Used Manual Review

3. Missing Event Emitting could be changed

##Impact Off-chain tools will not work as expected.

##Tool Used Manual Review

##Occurance

IVaultsCore.sol for VaultsCore

Missing Opened

https://github.com/code-423n4/2022-04-mimo/blob/b18670f44d595483df2c0f76d1c57a7bfbfbc083/core/contracts/interfaces/IVaultsCore.sol#L12

Missing Liquidate https://github.com/code-423n4/2022-04-mimo/blob/b18670f44d595483df2c0f76d1c57a7bfbfbc083/core/contracts/interfaces/IVaultsCore.sol#L17

1. Title : Change 2**256 - 1 to type(uint).max for saving more gas

Its cheaper to using type(uint).max instead of using 2**256-1 calculation for unlimited approval

##Tools Used Manual Review

##Recommended Mitigation

uint256 private constant MAX_INT = type(uint).max;

##Occurances VaultsCore#L23 InceptionVaultsCore#L23 PARMinerV2.sol#L58

2. Title : Saving gas by removing = 0

https://github.com/code-423n4/2022-04-mimo/blob/b18670f44d595483df2c0f76d1c57a7bfbfbc083/core/contracts/core/VaultsCore.sol#L402

If a variable was not set/initialized, it is assumed to have default value to 0 this implementation was used for saving more gas by removing = 0

##TOOLS USED Manual Review

##Mitigation Step Remove = 0

3. Title : Shorter code for saving more gas

https://github.com/code-423n4/2022-04-mimo/blob/b18670f44d595483df2c0f76d1c57a7bfbfbc083/core/contracts/liquidityMining/PARMiner.sol#L223-L224

this implementation below can be used for saving more gas. since it called once, so you dont need to declare _accAmountPerShare for userInfo.accParAmountPerShare. it can be directly into userInfo.accAmountPerShare.

##Tool Used Manual Review

##Recommended Mitigation

    userInfo.accAmountPerShare = _accAmountPerShare;
    userInfo.accParAmountPerShare = _accParAmountPerShare;

changed to

    userInfo.accParAmountPerShare = userInfo.accAmountPerShare