Mimo DeFi contest - sikorico's results

Code Quality Report

[Low-01] Add a timelock

It is good to have a timelock for functions that set key/critical variables.

• ConfigProvider.sol#L48
• ConfigProvider.sol#L139
• ConfigProvider.sol#L150
• ConfigProvider.sol#L181
• ConfigProvider.sol#L204

[Low-02] Assert instead require to validate user inputs

From solidity docs: Properly functioning code should never reach a failing assert statement; if this happens there is a bug in your contract which you should fix. With assert the user pays the gas and with require it does not. The ETH network gas is not cheap and users can see it as a scam.

• TInceptionVaultHealthy.sol#L83
• TInceptionVaultUnhealthy.sol#L116
• TInceptionVaultUnhealthyAssertion.sol#L62
• TInceptionVaultUnhealthyAssertion.sol#L88

[Low-03] Init function exposed to a front-run attack

This is a small frontrun issue but still worth mentioning. One can frontrun your init function and then stuck the system since you will not be able to use the function again:

• AdminInceptionVault.sol#L35
• ChainlinkInceptionPriceFeed.sol#L29
• SuperVault.sol#L49

[Low-04] Loss of precision

Doing multiplication before the divisions leads to better precision.

• GUniLPOracle.sol#L107

[Low-05] open TODOs

You have open TODOs:

• GenericMiner.sol#L90
• GenericMiner.sol#L112
• PARMiner.sol#L162
• PARMiner.sol#L165
• PARMiner.sol#L199

[Low-06] Not preventing transfer to address(0)

Transferring tokens to the zero address is usually prohibited to accidentally avoid "burning" tokens by sending them to an unrecoverable zero address.

• MIMOBuyBack.sol#L51
• MIMOBuybackUniswapV2.sol#L50