Platform: Code4rena
Start Date: 05/05/2022
Pot Size: $125,000 DAI
Total HM: 17
Participants: 62
Period: 14 days
Judge: leastwood
Total Solo HM: 15
Id: 120
League: ETH
Rank: 41/62
Findings: 2
Award: $267.81
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: IllIllI
Also found by: 0x1f8b, 0x4non, 0xDjango, 0xNazgul, 0xkatana, 0xsomeone, AuditsAreUS, BouSalman, BowTiedWardens, Cityscape, Funen, GimelSec, Hawkeye, JC, MaratCerby, MiloTruck, Picodes, Ruhum, TerrierLover, WatchPug, Waze, bobirichman, catchup, cccz, cryptphi, csanuragjain, delfin454000, ellahi, fatherOfBlocks, hake, horsefacts, hyh, jayjonah8, joestakey, kebabsec, kenta, mics, oyc_109, robee, samruna, shenwilly, sikorico, simon135, throttle, tintin
178.3839 DAI - $178.38
I. Variables are already their defaults.
TransmuterV2.sol
setPause() already exists to alter the flag. Therefore, there's no need to set isPaused=false in initialize() since that's the default before alteration.
StakingPools.sol
ThreePoolAssetManager.sol
II. Grammatical errors
Remove ‘is’ :
III. Use assignment operator( +=/-=) for better readability :
https://github.com/code-423n4/2022-05-alchemix/blob/main/contracts-full/StakingPools.sol#L379-L380
[https://github.com/code-423n4/2022-05-alchemix/blob/main/contracts-full/StakingPools.sol#L397-L398
🌟 Selected for report: IllIllI
Also found by: 0v3rf10w, 0x1f8b, 0x4non, 0xDjango, 0xNazgul, 0xf15ers, 0xkatana, 0xsomeone, AlleyCat, BowTiedWardens, Cityscape, Fitraldys, Funen, GimelSec, Hawkeye, JC, MaratCerby, MiloTruck, Randyyy, TerrierLover, Tomio, UnusualTurtle, WatchPug, Waze, _Adam, augustg, bobirichman, catchup, csanuragjain, ellahi, fatherOfBlocks, hake, hansfriese, horsefacts, ignacio, joestakey, kenta, mics, oyc_109, robee, samruna, sashik_eth, sikorico, simon135, throttle
89.4325 DAI - $89.43
I. Reorder the state variables to reduce the slotw utilised
IAlchemistV2State.sol
The struct underlyingTokenParams takes up three separate slots, it can be reduced to two.
Place the bool at the second position.
Same for :
bool can be moved below uint8 decimals.
II. Use unchecked block for gas savings :
#0 - 0xfoobar
2022-05-30T06:54:09Z
Correct on struct reducing its slots