Platform: Code4rena
Start Date: 05/05/2022
Pot Size: $125,000 DAI
Total HM: 17
Participants: 62
Period: 14 days
Judge: leastwood
Total Solo HM: 15
Id: 120
League: ETH
Rank: 48/62
Findings: 1
Award: $179.97
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: IllIllI
Also found by: 0x1f8b, 0x4non, 0xDjango, 0xNazgul, 0xkatana, 0xsomeone, AuditsAreUS, BouSalman, BowTiedWardens, Cityscape, Funen, GimelSec, Hawkeye, JC, MaratCerby, MiloTruck, Picodes, Ruhum, TerrierLover, WatchPug, Waze, bobirichman, catchup, cccz, cryptphi, csanuragjain, delfin454000, ellahi, fatherOfBlocks, hake, horsefacts, hyh, jayjonah8, joestakey, kebabsec, kenta, mics, oyc_109, robee, samruna, shenwilly, sikorico, simon135, throttle, tintin
179.9731 DAI - $179.97
AlchemicTokenV2 - flashMintFee could be set to an incorrect valueIn setFlashFeeMint, flashMintFee can be set to a value superior to 10000, so adding a require wouldn’t cost much and would add additional safety.
This is also true for setSwapFees
setSentinel already natively existhttps://github.com/OpenZeppelin/openzeppelin-contracts/blob/57725120581e27ec469e1c7e497a4008aafff818/contracts/access/AccessControl.sol#L142The function grantRole does the same thing as setSentinel, so there is no real need for this function.
Comment for mint in AlchemicTokenV2 is incorrect here: there is no mineable ceiling.
#0 - 0xfoobar
2022-05-30T07:48:36Z
Useful QA