Platform: Code4rena
Start Date: 13/05/2022
Pot Size: $30,000 USDC
Total HM: 8
Participants: 65
Period: 3 days
Judge: hickuphh3
Total Solo HM: 1
Id: 125
League: ETH
Rank: 34/65
Findings: 2
Award: $69.38
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: IllIllI
Also found by: 0x1f8b, 0x4non, 0xNazgul, 0xf15ers, 0xkatana, 0xliumin, AlleyCat, BouSalman, Dravee, Funen, GimelSec, Hawkeye, MaratCerby, Picodes, StErMi, TerrierLover, WatchPug, Waze, berndartmueller, bobirichman, cryptphi, csanuragjain, defsec, delfin454000, dipp, fatherOfBlocks, hake, hickuphh3, hyh, joestakey, kebabsec, mics, mtz, oyc_109, p4st13r4, p_crypt0, robee, rotcivegaf, sikorico, simon135, sorrynotsorry, tintin
45.925 USDC - $45.92
I. Declared variables are already their defaults, no need to assign.
ConvexCurveLPVault.sol
GeneralVault.sol
YieldManager.sol
II.Check that the same asset is not added more than once:
III. Ensure that there is adequate balance before calling the function mentioned :
add, if (amount≠0) {
convertAssetToExchangeToken() ;
}
IV. The interface provided is not in scope but it makes a call from processYield()
The above interface doesn't return anything but Convex's base Reward Pool returns a Boolean on a successful withdrawal of rewards:
#0 - HickupHH3
2022-06-06T09:08:14Z
Low: II, III NC: I, IV
🌟 Selected for report: IllIllI
Also found by: 0v3rf10w, 0x1f8b, 0x4non, 0xNazgul, 0xf15ers, 0xkatana, 0xliumin, Cityscape, Dravee, Fitraldys, Funen, GimelSec, Hawkeye, JC, MaratCerby, SooYa, StErMi, Tomio, WatchPug, Waze, bobirichman, defsec, delfin454000, fatherOfBlocks, hake, hansfriese, hickuphh3, ignacio, joestakey, kebabsec, mics, mtz, oyc_109, robee, rotcivegaf, samruna, sikorico, simon135, z3s
23.4569 USDC - $23.46
since extraYieldAmount is already initialised
On L160, replace _totalYield Amount with the local variable mentioned above.