Juicebox contest - JC's results

The decentralized fundraising and treasury protocol.

General Information

Platform: Code4rena

Start Date: 18/10/2022

Pot Size: $50,000 USDC

Total HM: 13

Participants: 67

Period: 5 days

Judge: Picodes

Total Solo HM: 7

Id: 172

League: ETH

Juicebox

Findings Distribution

Researcher Performance

Rank: 54/67

Findings: 1

Award: $25.96

Gas:

grade-b

🌟 Selected for report: 0

🚀 Solo Findings: 0

External Links

Code4rena Contest Page Github Contest Repository Github Findings Repository Juicebox

Findings Information

🌟 Selected for report: Jeiwan

Also found by: 0x1f8b, 0x4non, 0x5rings, 0xSmartContract, Awesome, Aymen0909, Bnke0x0, CodingNameKiki, Diana, DimSon, JC, JrNet, LeoS, RaymondFam, ReyAdmirado, Saintcode_, Shinchan, __141345__, berndartmueller, bharg4v, brgltd, carlitox477, ch0bu, chaduke, cryptostellar5, emrekocak, gogo, lukris02, martin, mcwildy, sakman, trustindistrust, zishansami

Awards

25.9629 USDC - $25.96

Labels

bug

G (Gas Optimization)

grade-b

G-32

External Links

Link to GitHub issue

G-01 Multiple address mappings can be combined into a single mapping of an address to a struct, where appropriate (16 instances) G-02 State variables only set in the constructor should be declared immutable (1 instance) G-03 Using calldata instead of memory for read-only arguments in external functions saves gas (27 instances) G-04 <x> += <y> costs more gas than <x> = <x> + <y> for state variables (6 instances) G-05 Use simple comparison in trinary logic / in if statement (2 instances)

Total: 52 instances in 5 issues

G-01 Multiple address mappings can be combined into a single mapping of an address to a struct, where appropriate

Saves a storage slot for the mapping. Depending on the circumstances and sizes of types, can avoid a Gsset (20000 gas) per mapping combined. Reads and subsequent writes can also be cheaper when a function requires both values and they both fit in the same storage slot.

16 instances in 1 file:

G-02 State variables only set in the constructor should be declared immutable

Avoids a Gsset (20000 gas) in the constructor, and replaces each Gwarmacces (100 gas) with a PUSH32 (3 gas).

1 instance in 1 file:

JBTiered721Delegate.sol https://github.com/jbx-protocol/juice-nft-rewards/blob/f9893b1497098241dd3a664956d8016ff0d0efd0/contracts/JBTiered721Delegate.sol#L48

G-03 Using calldata instead of memory for read-only arguments in external functions saves gas

When a function with a memory array is called externally, the abi.decode() step has to use a for-loop to copy each index of the calldata to the memory index. Each iteration of this for-loop costs at least 60 gas (i.e. 60 * <mem_array>.length). Using calldata directly, obliviates the need for such a loop in the contract code and runtime execution. Structs have the same overhead as an array of length one

27 instances in 5 files:

JB721TieredGovernance.sol https://github.com/jbx-protocol/juice-nft-rewards/blob/f9893b1497098241dd3a664956d8016ff0d0efd0/contracts/JB721TieredGovernance.sol#L147 https://github.com/jbx-protocol/juice-nft-rewards/blob/f9893b1497098241dd3a664956d8016ff0d0efd0/contracts/JB721TieredGovernance.sol#L313

JBTiered721DelegateDeployer.sol https://github.com/jbx-protocol/juice-nft-rewards/blob/f9893b1497098241dd3a664956d8016ff0d0efd0/contracts/JBTiered721DelegateDeployer.sol#L71

JB721GlobalGovernance.sol https://github.com/jbx-protocol/juice-nft-rewards/blob/f9893b1497098241dd3a664956d8016ff0d0efd0/contracts/JB721GlobalGovernance.sol#L55

G-04 <x> += <y> costs more gas than <x> = <x> + <y> for state variables

6 instances in 1 file:

G-05 Use simple comparison in trinary logic / in if statement

The comparison operators >= and <= use more gas than >, <, or ==. Replacing the >= and ≤ operators with a comparison operator that has an opcode in the EVM saves gas. Recommended Mitigation Steps: Replace the comparison operator and reverse the logic to save gas using the suggestions above.

2 instances in 2 files:

JBTiered721DelegateStore.sol https://github.com/jbx-protocol/juice-nft-rewards/blob/f9893b1497098241dd3a664956d8016ff0d0efd0/contracts/JBTiered721DelegateStore.sol#L903

JB721TieredGovernance.sol https://github.com/jbx-protocol/juice-nft-rewards/blob/f9893b1497098241dd3a664956d8016ff0d0efd0/contracts/JB721TieredGovernance.sol#L133

#0 - c4-judge
2022-11-08T18:16:54Z

Picodes marked the issue as grade-b

Juicebox contest - JC's results

The decentralized fundraising and treasury protocol.

General Information

Findings Distribution

Researcher Performance

External Links

[G-32] Gas Report - $25.96

Findings Information

Awards

Labels

External Links

G-01 Multiple address mappings can be combined into a single mapping of an address to a struct, where appropriate

G-02 State variables only set in the constructor should be declared immutable

G-03 Using calldata instead of memory for read-only arguments in external functions saves gas

G-04 <x> += <y> costs more gas than <x> = <x> + <y> for state variables

G-05 Use simple comparison in trinary logic / in if statement

#0 - c4-judge2022-11-08T18:16:54Z

#0 - c4-judge
2022-11-08T18:16:54Z