Aura Finance contest - JDeryl's results

QA Report (Low/Non-Critical)

File AuraVestedEscrow.sol

Issue: checks-effects-interactions pattern missing

Description: Lines: 123-125 Though the function cancel(address _recipient) ensures using the non-reentrant modifier, it is however suggested based on best practices that the checks-effects-interactions pattern be implemented for all functions containing external calls.

Current Code:

    function cancel(address _recipient) external nonReentrant {
        require(msg.sender == admin, "!auth");
        require(totalLocked[_recipient] > 0, "!funding");

        _claim(_recipient, false);

        uint256 delta = remaining(_recipient);
        rewardToken.safeTransfer(admin, delta);

        totalLocked[_recipient] = 0;

        emit Cancelled(_recipient);
    }

Suggestion: Hence the lines of code can be swapped to ensure the best practice remain intact as follows.

    function cancel(address _recipient) external nonReentrant {
        require(msg.sender == admin, "!auth");
        require(totalLocked[_recipient] > 0, "!funding");

        _claim(_recipient, false);

        uint256 delta = remaining(_recipient);
        totalLocked[_recipient] = 0;
        
        rewardToken.safeTransfer(admin, delta);

        emit Cancelled(_recipient);
    }