Aura Finance contest - cthulhu_cult's results

Issue: Floating Pragma

• Ref: SWC-103
• Severity: Quality assurance
• Description: pragma solidity ^0.8.11;
• Locations: Project wide
• Remediation: Lock the pragma version and also consider known bugs for the compiler version that is chosen.

Issue: Violation of check-effects-interactions pattern

• Severity: Quality Assurance.
• Description: The require statement in the constructor is evaluated after effects on the state.
• Count: 1
• Locations: AuraBalRewardPool.sol#L77
• Remediation: The require statement should be evaluated first.

Issue: Unnecessary code

• Ref: SWC-135
• Severity: Quality Assurance.
• Description: ABIEncoderV2 is the default as of version 0.8.0 no need to include the statement.
• code: pragma experimental ABIEncoderV2;

Gas Optimizations: No need to initialize variables with default values.

• Count: 3
• Locations: AuraBalRewardPool.sol#L35,L38,L39
• Poc: uint256 public pendingPenalty = 0;

Gas Optimizations: Use custom errors as of solidity 0.8.4

• Description: Custom errors from Solidity 0.8.4 are cheaper than revert strings. Replace revert strings with custom errors.
• Locations: Project Wide