Timeswap contest - OriDabush's results

Handle

OriDabush

Vulnerability details

TimeswapPair.sol - Gas Optimization

calculate the condition in line 362 before the loop instead of calculating it in every iteration.

code before:

for (uint256 i; i < ids.length; i++) {
            ...
            if (owner != msg.sender) require(collateralsOut[i] == 0, 'E213');
            ...
}

code after:

bool condition = (owner != msg.sender);
for (uint256 i; i < ids.length; i++) {
            ...
            if (condition) require(collateralsOut[i] == 0, 'E213');
            ...
}

Handle

OriDabush

Vulnerability details

TimeswapPair.sol - Gas Optimization

calculate BlockNumber.get() before the loop in line 289 and save it in a variable to prevent calculating it (and calling the get function) in every iteration.

code before:

for (uint256 i; i < ids.length; i++) {
            ...
            require(due.startBlock != BlockNumber.get(), 'E207');
            ...
}

code after:

uint32 startblock = BlockNumber.get();
for (uint256 i; i < ids.length; i++) {
            ...
            require(due.startBlock != startblock , 'E207');
            ...
}

Handle

OriDabush

Vulnerability details

TimeswapPair.sol gas optimization

In line 359 in the TimeswapPair contract, you can prefix increment the loop index instead of postfix incrementing it. This change will save gas (it will prevent a useless operation in every iteration of the loop).

code before: for (uint256 i; i < ids.length; i++) { ... }

code after: for (uint256 i; i < ids.length; ++i) { ... }

Handle

OriDabush

Vulnerability details

TimeswapPair.sol - Gas Optimization

Lines 289-290 can be transferred into the if statements to avoid subtract 0 from the variables.

code before:

pool.state.reserves.asset -= tokensOut.asset;

pool.state.reserves.collateral -= tokensOut.collateral;

if (tokensOut.asset > 0) asset.safeTransfer(assetTo, tokensOut.asset);

if (tokensOut.collateral > 0) collateral.safeTransfer(collateralTo, tokensOut.collateral);

code after:

if (tokensOut.asset > 0) { asset.safeTransfer(assetTo, tokensOut.asset); pool.state.reserves.asset -= tokensOut.asset; }

if (tokensOut.collateral > 0) { collateral.safeTransfer(collateralTo, tokensOut.collateral); pool.state.reserves.collateral -= tokensOut.collateral; }