Behodler contest - Randyyy's results

Handle

Randyyy

Vulnerability details

Impact

By saving array length to variable the loop does not have to get the array length value each loop and can save gas

Proof of Concept

https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/LimboDAO.sol#L212 https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/LimboDAO.sol#L217

Navigation

uint counter = sushiLPs.length
for (uint256 i = 0; i < counter; i++) {
      require(UniPairLike(sushiLPs[i]).factory() == sushiFactory, "LimboDAO: invalid Sushi LP");
      if (IERC20(eye).balanceOf(sushiLPs[i]) > 1000) assetApproved[sushiLPs[i]] = true;
      fateGrowthStrategy[sushiLPs[i]] = FateGrowthStrategy.indirectTwoRootEye;
    }

Handle

Randyyy

Vulnerability details

Impact

Since this function does not change sushiLPs and uniLPs parameter its cheaper to use calldata instead memory

Proof of Concept

https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/LimboDAO.sol#L204 https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/LimboDAO.sol#L205

Tools Used

Remix

Recommended Mitigation Steps

Change memory to call data

Handle

Randyyy

Vulnerability details

Impact

Save gas, because Using type(uint).max is cheaper than using calculation 2**256 - 1.

Proof of Concept

https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/FlanBackstop.sol#L36

##Navigation

constructor(
    address dao,
    address flan,
    address pyroFlan
  ) Governable(dao) {
    config.pyroFlan = pyroFlan;
    config.flan = flan;
    IERC20(flan).approve(pyroFlan, type(uint).max);
  }