Behodler contest - throttle's results

Handle

throttle

Vulnerability details

Impact

Gas optimization

Proof of Concept

Accessing array length in for loop is costly. https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/LimboDAO.sol#L212 https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/LimboDAO.sol#L217

Tools Used

Manual review

Recommended Mitigation Steps

Consider caching length before the for loop.

uint256 length = sushiLPs.length
for (uint256 i; i < length; i++) {
    ...
}

Handle

throttle

Vulnerability details

Impact

Gas savings

Proof of Concept

Using pre-increment (++i) instead of post-increment (i++) saves few unit of gas every spin of the loop: https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/LimboDAO.sol#L212 https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/LimboDAO.sol#L217

Tools Used

Manual review

Recommended Mitigation Steps

Change i++ to ++i

Handle

throttle

Vulnerability details

Impact

Gas savings

Proof of Concept

Assigning default values costs unnecessary gas. https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/LimboDAO.sol#L212 https://github.com/code-423n4/2022-01-behodler/blob/main/contracts/DAO/LimboDAO.sol#L217

Tools Used

Manual review

Recommended Mitigation Steps

Consider rewriting

for (uint256 i = 0; i < k; i++) {
    ...
}

to

for (uint256 i; i < k; i++) {
    ...
}