Juicebox contest - RaoulSchaffranek's results

The decentralized fundraising and treasury protocol.

General Information

Platform: Code4rena

Start Date: 18/10/2022

Pot Size: $50,000 USDC

Total HM: 13

Participants: 67

Period: 5 days

Judge: Picodes

Total Solo HM: 7

Id: 172

League: ETH

Juicebox

Findings Distribution

Researcher Performance

Rank: 52/67

Findings: 1

Award: $37.88

QA:
grade-b

🌟 Selected for report: 0

🚀 Solo Findings: 0

Lines of code

https://github.com/jbx-protocol/juice-nft-rewards/blob/f9893b1497098241dd3a664956d8016ff0d0efd0/contracts/JB721TieredGovernance.sol#L287

Vulnerability details

Impact

The JB721TieredGovernance._moveTierDelegateVotes function emits a TierDelegateVotesChanged event with the wrong argument order. Events are used to communicate with the outside world - in particular, web3 uses events to obtain information from the blockchain to display on a website. The bug can affect the appearance of the Web3 front end. In the best case, the event is never used in the front end, and no harm is done. In the worst case, an attacker can exploit the situation to mislead users and convince them that he or somebody else holds a certain voting power.

Proof of Concept

https://github.com/jbx-protocol/juice-nft-rewards/blob/f9893b1497098241dd3a664956d8016ff0d0efd0/contracts/JB721TieredGovernance.sol#L287

Tools Used

VSCode

Reorder the parameters to match the argument order of the TierDelegateVotesChanged-definition.

#0 - drgorillamd

2022-10-24T10:41:42Z

Duplicate #93

#1 - c4-judge

2022-12-03T19:10:07Z

Picodes marked the issue as not a duplicate

#2 - c4-judge

2022-12-03T19:10:14Z

Picodes changed the severity to QA (Quality Assurance)

#3 - c4-judge

2022-12-03T19:10:23Z

Picodes marked the issue as grade-b

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter