Axelar Network v2 contest - RedOneN's results

[L-01] Unused RECEIVE() Function will lock ether in contract.

If the intention is for the Ether to be used, the function should call another function, otherwise it should revert

File: DepositReceiver.sol DepositReceiver.sol#L29

[L-02] Missing Checks for APPROVE()'s return status

Some tokens, such as Tether (USDT) return false rather than reverting if the approval fails. Use OpenZeppelin’s safeApprove(), which reverts if there’s a failure, instead.

File: AxelarDepositService.sol AxelarDepositService.sol#L30

File: ReceiverImplementation.sol ReceiverImplementation.sol#L38 ReceiverImplementation.sol#L64 ReceiverImplementation.sol#L86

[N-01] Consider using a more recent version of solidity

[G-01] - Functions guaranteed to revert when called by normal users (such as onlyOwner) can be marked payable.

File: AxelarGasService.sol AxelarGasService.sol#L120 AxelarGasService.sol#L136

[G-02] ++i/i++ should be UNCHECKED{++i}/UNCHECKED{i++} when it is not possible for them to overflow, as is the case when used in for and while loops.

File: AxelarGasService.sol AxelarGasService.sol#L123

File: AxelarDepositService.sol# AxelarDepositService.sol#L114 AxelarDepositService.sol#L168 AxelarDepositService.sol#L204

###[G-03] ++i costs less gas than i++, especially when it's use in for loops

File: AxelarGasService.sol AxelarGasService.sol#L123

File: AxelarDepositService.sol# AxelarDepositService.sol#L114 AxelarDepositService.sol#L168 AxelarDepositService.sol#L204

[G-04] Consider using a more recent version of solidity

Use a solidity version of at least 0.8.10 to have external calls skip contract existence checks if the external call has a return value

[G-05] Consider turning some constant variable as private to save Gas.

FileAxelarDepositService.sol AxelarDepositService.sol#L16

[G-06] Using > 0 costs more gas than != 0 when used on a uint.

File: AxelarDepositService.sol AxelarDepositService.sol#L165