Axelar Network v2 contest - ReyAdmirado's results

wrong cyntax for custom errors

example: revert('NotAxelarToken()'); should be revert NotAxelarToken();

• XC20Wrapper.sol#L55
• XC20Wrapper.sol#L56
• XC20Wrapper.sol#L57
• XC20Wrapper.sol#L58
• XC20Wrapper.sol#L61
• XC20Wrapper.sol#L62
• XC20Wrapper.sol#L68
• XC20Wrapper.sol#L70
• XC20Wrapper.sol#L78
• XC20Wrapper.sol#L79
• XC20Wrapper.sol#L84
• XC20Wrapper.sol#L85
• XC20Wrapper.sol#L86
• XC20Wrapper.sol#L98
• XC20Wrapper.sol#L111

1. <array>.length should not be looked up in every loop of a for-loop

• AxelarDepositService.sol#L114

• AxelarDepositService.sol#L168

• AxelarDepositService.sol#L204

• AxelarGasService.sol#L123

• AxelarGateway.sol#L207

• AxelarAuthWeighted.sol#L17

• AxelarAuthWeighted.sol#L98

• AxelarAuthWeighted.sol#L116

2. can make the variable outside the loop to save gas

• AxelarDepositService.sol#L115

• AxelarDepositService.sol#L205

• AxelarGasService.sol#L124

• AxelarGasService.sol#L127

• AxelarGateway.sol#L208

• AxelarGateway.sol#L209

• AxelarGateway.sol#L293

• AxelarGateway.sol#L297

• AxelarGateway.sol#L298

• AxelarAuthWeighted.sol#L98

3. better to use ++i than i++

• AxelarDepositService.sol#L114

• AxelarDepositService.sol#L168

• AxelarDepositService.sol#L204

• AxelarGasService.sol#L123

• AxelarGateway.sol#L207

4. it costs more gas to initialize variables to zero than to let the default of zero be applied

• AxelarGateway.sol#L207

• AxelarAuthWeighted.sol#L68

• AxelarAuthWeighted.sol#L69

• AxelarAuthWeighted.sol#L94

• AxelarAuthWeighted.sol#L95

• AxelarAuthWeighted.sol#L98

5. expressions for constant values such as a call to keccak256(), should use immutable rather than constant

• AxelarGateway.sol#L30

• AxelarGateway.sol#L31

• AxelarGateway.sol#L32

• AxelarGateway.sol#L33

• AxelarGateway.sol#L34

• AxelarGateway.sol#L35

• AxelarGateway.sol#L36

• AxelarGateway.sol#L38

• AxelarGateway.sol#L39

• AxelarGateway.sol#L40

• AxelarGateway.sol#L41

• AxelarGateway.sol#L42

• AxelarGateway.sol#L43

6. use a more recent version of solidity

Use a solidity version of at least 0.8.10 to have external calls skip contract existence checks if the external call has a return value

7. ++i/i++ should be unchecked{++i}/unchecked{++i} when it is not possible for them to overflow, as is the case when used in for-loops and while-loops