VTVL contest - Tadashi's results

Variables with default value do not need to be initialized

Summary: state variable numTokensReservedForVesting of VTVLVesting contract and variable vestAmt in function _baseVestedAmount do not need to be initialized.

Details: Perform these changes:

• in L27 of VTVLVesting.sol:

  -uint112 public numTokensReservedForVesting = 0;
  +uint112 public numTokensReservedForVesting;

• in L148 of VTVLVesting.sol:

  -uint112 vestAmt = 0;
  +uint112 vestAmt;

⛽ Profiling:

By performing these changes the average gas used (computed using thnpx hardhat test) can be decreased:

• revokeClaim(): 40827 → 40819
• withdraw(): 72938 → 72930
• Deployment of VTVLVesting: 3740739 → 3737632

Post-increments that can be replaced by pre-increments

Summary: Pre-incrementing a variable is cheaper than post-incrementing it. For more information, see G012 of c4-common-issues.

Details: Consider the following change to L353 of VTVLVesting.sol:

-for (uint256 i = 0; i < length; i++) {
+for (uint256 i = 0; i < length; ++i) {

⛽ Profiling:

By performing these changes the average gas used (computed using thnpx hardhat test) can be decreased:

• revokeClaim(): 40827 → 40819
• createClaim(): 167760 → 167759
• createClaimsBatch(): 284486 → 284476
• Deployment of VTVLVesting: 3740739 → 3740295