Canto v2 contest - ajtra's results

Execution layer for original work.

General Information

Platform: Code4rena

Start Date: 28/06/2022

Pot Size: $25,000 USDC

Total HM: 14

Participants: 50

Period: 4 days

Judge: GalloDaSballo

Total Solo HM: 7

Id: 141

League: ETH

Canto

Findings Distribution

Researcher Performance

Rank: 49/50

Findings: 1

Award: $21.80

🌟 Selected for report: 0

🚀 Solo Findings: 0

External Links

Code4rena Contest Page Github Contest Repository Github Findings Repository Canto

Findings Information

🌟 Selected for report: 0x1f8b

Also found by: 0x29A, 0xArshia, 0xKitsune, Bnke0x0, Chom, Fitraldys, Funen, JC, Lambda, Meera, Noah3o6, Picodes, RedOneN, Rohan16, Sm4rty, TerrierLover, TomJ, Tomio, Waze, ajtra, c3phas, cRat1st0s, defsec, durianSausage, fatherOfBlocks, grGred, hake, ladboy233, m_Rassska, mrpathfindr, oyc_109, rfa, ynnad

Awards

21.8032 USDC - $21.80

Labels

bug

G (Gas Optimization)

External Links

Link to GitHub issue

Type 2) - Expressions for constant values such as a call to KECCAK256 should use IMMUTABLE rather than constant GovernorBravoDelegate.sol line 15 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L15 bytes32 public constant DOMAIN_TYPEHASH = keccak256("EIP712Domain(string name,uint256 chainId,address verifyingContract)");

GovernorBravoDelegate.sol line 18 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L18 bytes32 public constant BALLOT_TYPEHASH = keccak256("Ballot(uint256 proposalId,uint8 support)");

TreasuryDelegate.sol line 12 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Treasury/TreasuryDelegate.sol#L12 bytes32 constant cantoDenom = keccak256(bytes("CANTO"));

TreasuryDelegate.sol line 13 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Treasury/TreasuryDelegate.sol#L13 bytes32 constant noteDenom = keccak256(bytes("NOTE"));

Type 3) - Array length should not be looked up in every loop of a for-loop. Storage array length checks incur an extra Gwarmaccess (100 gas) per loop. Store the array length in a variable and use it in the for loop helps to save gas Comptroller.sol line 742 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L742 for (uint i = 0; i < assets.length; i++) {

Comptroller.sol line 964 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L964 for (uint i = 0; i < allMarkets.length; i ++) {

Comptroller.sol line 1111 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1111 for (uint i = 0; i < affectedUsers.length; ++i) {

Comptroller.sol line 1352 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1352 for (uint i = 0; i < cTokens.length; i++) {

Comptroller.sol line 1358 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1358 for (uint j = 0; j < holders.length; j++) {

Comptroller.sol line 1364 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1364 for (uint j = 0; j < holders.length; j++) {

Comptroller.sol line 1369 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1369 for (uint j = 0; j < holders.length; j++) {

GovernorBravoDelegate.sol line 66 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L66 for (uint i = 0; i < newProposal.targets.length; i++) {

GovernorBravoDelegate.sol line 88 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L88 for (uint i = 0; i < proposal.targets.length; i++) {

BaseV1-core.sol line 210 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L210 for (uint i = 0; i < _prices.length; i++) {

BaseV1-periphery.sol line 154 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L154 for (uint i = 0; i < routes.length; i++) {

BaseV1-periphery.sol line 380 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L380 for (uint i = 0; i < routes.length; i++) {

Type 4) - Require instead of &&. Split of conditions of an require sentence in different requires sentences can save gas

Comptroller.sol line 1008 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1008 require(numMarkets != 0 && numMarkets == numBorrowCaps, "invalid input");

Comptroller.sol line 1416 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1416 require(numTokens == supplySpeeds.length && numTokens == borrowSpeeds.length, "Comptroller::_setCompSpeeds invalid input");

GovernorBravoDelegate.sol line 42 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L42 require(unigovProposal.targets.length == unigovProposal.values.length && line 43 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L43 unigovProposal.targets.length == unigovProposal.signatures.length && line 44 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L44 unigovProposal.targets.length == unigovProposal.calldatas.length,

BaseV1-core.sol line 275 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L275 require(amount0 > 0 && amount1 > 0, 'ILB'); // BaseV1: INSUFFICIENT_LIQUIDITY_BURNED

BaseV1-core.sol line 291 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L291 require(amount0Out < _reserve0 && amount1Out < _reserve1, 'IL'); // BaseV1: INSUFFICIENT_LIQUIDITY

BaseV1-core.sol line 297 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L297 require(to != _token0 && to != _token1, 'IT'); // BaseV1: INVALID_TO

BaseV1-core.sol line 434 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L434 require(recoveredAddress != address(0) && recoveredAddress == owner, 'BaseV1: INVALID_SIGNATURE');

BaseV1-core.sol line 471 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L471 require(success && (data.length == 0 || abi.decode(data, (bool))));

BaseV1-periphery.sol line 123 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L123 require(reserveA > 0 && reserveB > 0, "BaseV1Router: INSUFFICIENT_LIQUIDITY");

BaseV1-periphery.sol line 477 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L477 require(success && (data.length == 0 || abi.decode(data, (bool))));

Type 5) - Require strings longer than 32 bytes cost extra gas. Consider to shorten the string message in the following places in the code.

GovernorBravoDelegate.sol line 45 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L45 require(unigovProposal.targets.length == unigovProposal.values.length && unigovProposal.targets.length == unigovProposal.signatures.length && unigovProposal.targets.length == unigovProposal.calldatas.length, "GovernorBravo::propose: proposal function information arity mismatch");

CNote.sol line 17 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/CNote.sol#L17 require(msg.sender == admin, "CNote::_setAccountantContract:Only admin may call this function");

CNote.sol line 105 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/CNote.sol#L105 require(balanceCur == 0, "Accountant has not been correctly supplied");

CNote.sol line 148 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/CNote.sol#L148 require(token.balanceOf(address(this)) == 0, "cNote::doTransferOut: TransferOut Failed");

Comptroller.sol line 183 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L183 require(oErr == 0, "exitMarket: getAccountSnapshot failed"); // semi-opaque error code

Comptroller.sol line 496 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L496 require(borrowBalance >= repayAmount, "Can not repay more than the total borrow");

Comptroller.sol line 1003 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1003 require(msg.sender == admin || msg.sender == borrowCapGuardian, "only admin or borrow cap guardian can set borrow caps");

Comptroller.sol line 1021 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1021 require(msg.sender == admin, "only admin can set borrow cap guardian");

Comptroller.sol line 1056 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1056 require(markets[address(cToken)].isListed, "cannot pause a market that is not listed");

Comptroller.sol line 1057 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1057 require(msg.sender == pauseGuardian || msg.sender == admin, "only pause guardian and admin can pause");

Comptroller.sol line 1066 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1066 require(markets[address(cToken)].isListed, "cannot pause a market that is not listed");

Comptroller.sol line 1067 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1067 require(msg.sender == pauseGuardian || msg.sender == admin, "only pause guardian and admin can pause");

Comptroller.sol line 1076 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1076 require(msg.sender == pauseGuardian || msg.sender == admin, "only pause guardian and admin can pause");

Comptroller.sol line 1085 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1085 require(msg.sender == pauseGuardian || msg.sender == admin, "only pause guardian and admin can pause");

Comptroller.sol line 1094 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1094 require(msg.sender == unitroller.admin(), "only unitroller admin can change brains");

Comptroller.sol line 1100 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1100 require(msg.sender == admin, "Only admin can call this function"); // Only the timelock can call this function

Comptroller.sol line 1101 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1101 require(!proposal65FixExecuted, "Already executed this one-off function"); // Require that this function is only called once

Comptroller.sol line 1480 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1480 require(msg.sender == admin, "Only admin may initialize Weth Address");

NoteInterest.sol line 167 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/NoteInterest.sol#L167 require(msg.sender == admin, "only the admin may set the base rate");

NoteInterest.sol line 180 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/NoteInterest.sol#L180 require(msg.sender == admin, "only the admin may set the adjuster coefficient");

NoteInterest.sol line 193 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/NoteInterest.sol#L193 require(msg.sender == admin, "only the admin may set the update frequency");

WETH.sol line 29 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/WETH.sol#L29 require(_balanceOf[msg.sender] >= wamount, "sender balance insufficient for withdrawal");

WETH.sol line 72 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/WETH.sol#L72 require(_allowance[src][msg.sender] >= wad, "WETH::transferFrom:allowance insufficient");

WETH.sol line 89 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/WETH.sol#L89 require(owner != address(0), "ERC20: approve from the zero address");

WETH.sol line 90 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/WETH.sol#L90 require(spender != address(0), "ERC20: approve to the zero address");

AccountantDelegate.sol line 87 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Accountant/AccountantDelegate.sol#L87 require(cNoteAmt >= noteDiff, "AccountantDelegate::sweepInterest:Error calculating interest to sweep");

AccountantDelegate.sol line 101 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Accountant/AccountantDelegate.sol#L101 require(cnote.balanceOf(treasury) == 0, "AccountantDelegate::sweepInterestError");

AccountantDelegator.sol line 42 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Accountant/AccountantDelegator.sol#L42 require(msg.sender == admin, "AccountantDelegator::_setImplementation: admin only");

AccountantDelegator.sol line 43 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Accountant/AccountantDelegator.sol#L43 require(implementation_ != address(0), "AccountantDelegator::_setImplementation: invalid implementation address");

AccountantDelegator.sol line 123 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Accountant/AccountantDelegator.sol#L123 require(msg.value == 0,"AccountantDelegator:fallback: cannot send value to fallback");

GovernorBravoDelegate.sol line 25 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L25 require(address(timelock) == address(0), "GovernorBravo::initialize: can only initialize once");

GovernorBravoDelegate.sol line 26 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L26 require(msg.sender == admin, "GovernorBravo::initialize: admin only");

GovernorBravoDelegate.sol line 27 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L27 require(timelock_ != address(0), "GovernorBravo::initialize: invalid timelock address");

GovernorBravoDelegate.sol line 46 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L46 require(unigovProposal.targets.length != 0, "GovernorBravo::propose: must provide actions");

GovernorBravoDelegate.sol line 47 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L47 require(unigovProposal.targets.length <= proposalMaxOperations, "GovernorBravo::propose: too many actions");

GovernorBravoDelegate.sol line 76 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L76 require(!timelock.queuedTransactions(keccak256(abi.encode(target, value, signature, data, eta))), "GovernorBravo::queueOrRevertInternal: identical proposal action already queued at eta");

GovernorBravoDelegate.sol line 85 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L85 require(state(proposalId) == ProposalState.Queued, "GovernorBravo::execute: proposal can only be executed if it is queued");

GovernorBravoDelegate.sol line 128 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L128 require(msg.sender == admin, "GovernorBravo::_initiate: admin only");

GovernorBravoDelegate.sol line 129 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L129 require(initialProposalId == 0, "GovernorBravo::_initiate: can only initiate once");

GovernorBravoDelegate.sol line 140 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L140 require(msg.sender == admin, "GovernorBravo:_setPendingAdmin: admin only");

GovernorBravoDelegate.sol line 158 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L158 require(msg.sender == pendingAdmin, "GovernorBravo:_acceptAdmin: pending admin only");

BaseV1-periphery.sol line 104 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L104 require(tokenA != tokenB, "BaseV1Router: IDENTICAL_ADDRESSES");

BaseV1-periphery.sol line 122 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L122 require(amountA > 0, "BaseV1Router: INSUFFICIENT_AMOUNT");

BaseV1-periphery.sol line 241 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L241 require(amountBOptimal >= amountBMin, "BaseV1Router: INSUFFICIENT_B_AMOUNT");

BaseV1-periphery.sol line 246 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L246 require(amountAOptimal >= amountAMin, "BaseV1Router: INSUFFICIENT_A_AMOUNT");

BaseV1-periphery.sol line 313 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L313 require(amountA >= amountAMin, "BaseV1Router: INSUFFICIENT_A_AMOUNT");

BaseV1-periphery.sol line 314 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L314 require(amountB >= amountBMin, "BaseV1Router: INSUFFICIENT_B_AMOUNT");

BaseV1-periphery.sol line 405 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L405 require(amounts[amounts.length - 1] >= amountOutMin, "BaseV1Router: INSUFFICIENT_OUTPUT_AMOUNT");

BaseV1-periphery.sol line 420 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L420 require(amounts[amounts.length - 1] >= amountOutMin, "BaseV1Router: INSUFFICIENT_OUTPUT_AMOUNT");

BaseV1-periphery.sol line 435 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L435 require(amounts[amounts.length - 1] >= amountOutMin, "BaseV1Router: INSUFFICIENT_OUTPUT_AMOUNT");

BaseV1-periphery.sol line 448 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L448 require(amounts[amounts.length - 1] >= amountOutMin, "BaseV1Router: INSUFFICIENT_OUTPUT_AMOUNT");

BaseV1-periphery.sol line 470 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L470 require(success, "TransferHelper: ETH_TRANSFER_FAILED");

TreasuryDelegator.sol line 31 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Treasury/TreasuryDelegator.sol#L31 require(msg.sender == admin, "GovernorBravoDelegator::setImplementation: admin only");

TreasuryDelegator.sol line 32 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Treasury/TreasuryDelegator.sol#L32 require(implementation_ != address(0), "GovernorBravoDelegator::setImplementation: invalid implementation address");

TreasuryDelegator.sol line 121 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Treasury/TreasuryDelegator.sol#L121 require(msg.value == 0, "TreasuryDelegator::fallback:cannot send value to fallback");

Type 6) - Operatos <= or >= cost more gas than operators < or >. Change all <= / >= operators for < / > and remember to increse / decrese in consecuence to maintain the logic (example, a <= b for a < b + 1)

Comptroller.sol line 1248 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1248 if (supplierIndex == 0 && supplyIndex >= compInitialIndex)

Comptroller.sol line 1287 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1287 if (borrowerIndex == 0 && borrowIndex >= compInitialIndex)

Comptroller.sol line 1384 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1384 if (amount > 0 && amount <= compRemaining)

NoteInterest.sol line 150 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/NoteInterest.sol#L150 baseRatePerYear = ir >= 0 ? uint(ir) : 0;

WETH.sol line 69 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/WETH.sol#L69 require(_balanceOf[src] >= wad, "WETH::transfeFrom");

GovernorBravoDelegate.sol line 116 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L116 block.timestamp >= add256(proposal.eta, timelock.GRACE_PERIOD())

GovernorBravoDelegate.sol line 176 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L176 require(c >= a, "addition overflow");

GovernorBravoDelegate.sol line 181 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Governance/GovernorBravoDelegate.sol#L181 require(b <= a, "subtraction underflow");

BaseV1-core.sol line 312 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L312 require(_k(_balance0, _balance1) >= _k(_reserve0, _reserve1), 'K'); // BaseV1: K

BaseV1-core.sol line 351 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L351 if (y - y_prev <= 1)

BaseV1-core.sol line 355 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L355 if (y_prev - y <= 1)

BaseV1-core.sol line 416 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L416 require(deadline >= block.timestamp, 'BaseV1: EXPIRED');

BaseV1-periphery.sol line 151 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L151 require(routes.length >= 1, "BaseV1Router: INVALID_PATH");

BaseV1-periphery.sol line 187 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L187 if (amountBOptimal <= amountBDesired)

BaseV1-periphery.sol line 228 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L228 require(amountADesired >= amountAMin);

BaseV1-periphery.sol line 229 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L229 require(amountBDesired >= amountBMin);

BaseV1-periphery.sol line 240 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L240 if (amountBOptimal <= amountBDesired)

BaseV1-periphery.sol line 245 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L245 assert(amountAOptimal <= amountADesired);

BaseV1-periphery.sol line 509 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L509 if (stable >= 2)

- != 0 is cheaper than >. Replace all != 0 for > 0 Comptroller.sol line 314 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L314 if (shortfall > 0) {

Comptroller.sol line 334 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L334 if (redeemTokens == 0 && redeemAmount > 0) {

Comptroller.sol line 385 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L385 if (shortfall > 0) {

Comptroller.sol line 1134 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1134 if (amountToSubtract > 0) {

Comptroller.sol line 1199 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1199 if (deltaBlocks > 0 && supplySpeed > 0) {

Comptroller.sol line 1202 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1202 Double memory ratio = supplyTokens > 0 ? fraction(compAccrued, supplyTokens) : Double({mantissa: 0});

Comptroller.sol line 1205 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1205 } else if (deltaBlocks > 0) {

Comptroller.sol line 1220 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1220 if (deltaBlocks > 0 && borrowSpeed > 0) {

Comptroller.sol line 1223 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1223 Double memory ratio = borrowAmount > 0 ? fraction(compAccrued, borrowAmount) : Double({mantissa: 0});

Comptroller.sol line 1226 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1226 } else if (deltaBlocks > 0) {

Comptroller.sol line 1316 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1316 if (deltaBlocks > 0 && compSpeed > 0) {

Comptroller.sol line 1384 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L1384 if (amount > 0 && amount <= compRemaining) {

BaseV1-core.sol line 159 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L159 if (timeElapsed > 0 && _reserve0 != 0 && _reserve1 != 0) {

BaseV1-core.sol line 256 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L256 require(liquidity > 0, 'ILM'); // BaseV1: INSUFFICIENT_LIQUIDITY_MINTED

BaseV1-core.sol line 289 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L289 require(amount0Out > 0 || amount1Out > 0, 'IOA'); // BaseV1: INSUFFICIENT_OUTPUT_AMOUNT

BaseV1-core.sol line 298 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L298 if (amount0Out > 0) _safeTransfer(_token0, to, amount0Out); // optimistically transfer tokens

BaseV1-core.sol line 299 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L299 if (amount1Out > 0) _safeTransfer(_token1, to, amount1Out); // optimistically transfer tokens

BaseV1-core.sol line 300 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L300 if (data.length > 0) IBaseV1Callee(to).hook(msg.sender, amount0Out, amount1Out, data); // callback, used for flash loans

BaseV1-core.sol line 304 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L304 uint amount0In = _balance0 > _reserve0 - amount0Out ? _balance0 - (_reserve0 - amount0Out) : 0;

BaseV1-core.sol line 305 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L305 uint amount1In = _balance1 > _reserve1 - amount1Out ? _balance1 - (_reserve1 - amount1Out) : 0;

BaseV1-core.sol line 306 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L306 require(amount0In > 0 || amount1In > 0, 'IIA'); // BaseV1: INSUFFICIENT_INPUT_AMOUNT

BaseV1-core.sol line 468 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L468 require(token.code.length > 0);

BaseV1-periphery.sol line 474 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L474 require(token.code.length > 0);

BaseV1-periphery.sol line 481 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-periphery.sol#L481 require(token.code.length > 0, "token code length failure");

Type 8) - Variable1 = Variable1 + Variable2 is cheaper than variable1 += variable2. Replace all Var1 += (-=) Var2 for Var1 = Var1 + (-) Var2 WETH.sol line 23 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/WETH.sol#L23 _balanceOf[msg.sender] += msg.value;

WETH.sol line 30 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/WETH.sol#L30 _balanceOf[msg.sender] -= wamount;

WETH.sol line 73 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/WETH.sol#L73 _allowance[src][msg.sender] -= wad;

WETH.sol line 76 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/WETH.sol#L76 _balanceOf[src] -= wad;

WETH.sol line 77 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/WETH.sol#L77 _balanceOf[dst] += wad;

BaseV1-core.sol line 160 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L160 reserve0CumulativeLast += _reserve0 * timeElapsed;

BaseV1-core.sol line 161 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L161 reserve1CumulativeLast += _reserve1 * timeElapsed;

BaseV1-core.sol line 186 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L186 reserve0Cumulative += _reserve0 * timeElapsed;

BaseV1-core.sol line 187 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L187 reserve1Cumulative += _reserve1 * timeElapsed;

BaseV1-core.sol line 211 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L211 priceAverageCumulative += _prices[i];

BaseV1-core.sol line 229 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L229 for (; i < length; i+=window) {

BaseV1-core.sol line 397 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L397 totalSupply += amount;

BaseV1-core.sol line 398 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L398 balanceOf[dst] += amount;

BaseV1-core.sol line 403 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L403 totalSupply -= amount;

BaseV1-core.sol line 404 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L404 balanceOf[dst] -= amount;

BaseV1-core.sol line 461 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L461 balanceOf[src] -= amount;

BaseV1-core.sol line 462 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L462 balanceOf[dst] += amount;

Custom errors from Solidity 0.8.4 are cheaper than revert strings (cheaper deployment cost and runtime cost when the revert condition is met) while providing the same amount of information. Custom errors are defined using the error statement.

Comptroller.sol line 335 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L335

Unchecked Arithmetic. The default “checked” behavior costs more gas when adding/diving/multiplying, because under-the-hood those checks are implemented as a series of opcodes that, prior to performing the actual arithmetic, check for under/overflow and revert if it is detected. if it can statically be determined there is no possible way for your arithmetic to under/overflow (such as a condition in an if statement), surrounding the arithmetic in an unchecked block will save gas. In all loops in the code it’s possible to add an unchecked block for increment, for example, in Comptroller.sol line 964 could be as shown. https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L964

Default value initialization. If a variable is not set/initialized, it is assumed to have the default value (0, false, 0x0 etc depending on the data type). Explicitly initializing it with its default value is an anti-pattern and wastes gas.

For example, in the Comptroller.sol line 131 you can change the code FROM for (uint i = 0; i < len; i++) { TO for (uint i; i < len; i++) {

Consider to store the global variable in a local variable when it’s going to be used several times to avoid access to the storage that means an extra gas cost.

Store MINUMUM_LIQUIDITY in a local variable to use in the code: BaseV1-core.sol MINIMUM_LIQUIDITY line 251 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L251

BaseV1-core.sol MINIMUM_LIQUIDITY line 252 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Stableswap/BaseV1-core.sol#L252

Store Error in a local variable to use in the code: Comptroller.sol Error.NO_ERROR line 288 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L288

Comptroller.sol Error.NO_ERROR line 296 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L296

Comptroller.sol Error.NO_ERROR line 301 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L301

Comptroller.sol Error.NO_ERROR line 306 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L306

Comptroller.sol Error.NO_ERROR line 311 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L311

Comptroller.sol Error.NO_ERROR line 315 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L315

Comptroller.sol Error.NO_ERROR line 318 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L318

Comptroller.sol Error.NO_ERROR line 351 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L351

Comptroller.sol Error.NO_ERROR line 360 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L360

Comptroller.sol Error.NO_ERROR line 369 https://github.com/Plex-Engineer/lending-market-v2/blob/443a8c0fed3c5018e95f3881a31b81a555c42b2d/contracts/Comptroller.sol#L369