Canto v2 contest - hake's results

QA Report

[L-01] Missing zero address check

Mistakenly setting WethAddr to zero might lead to a loss of funds.

I recommend implementing a zero address check.

https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/Comptroller.sol#L1479

Gas Report

[G-01] for loop optimisation

for (uint i = 0; i < proposal.targets.length; i++) {
    timelock.executeTransaction{value: proposal.values[i]}(proposal.targets[i], proposal.values[i], proposal.signatures[i], proposal.calldatas[i], proposal.eta);
}

Gas could be saved by:

• Not initializing variable to default value of zero
• Caching array length
• Using a prefix (++i) instead of a postfix (i++)
• Unchecking increment count

Example:

uint length = proposal.targets.length;

for (uint i; i < length;) {
    timelock.executeTransaction{value: proposal.values[i]}(proposal.targets[i], proposal.values[i], proposal.signatures[i], proposal.calldatas[i], proposal.eta);
		unchecked { ++i; }
}

https://github.com/Plex-Engineer/lending-market-v2/blob/main/contracts/Governance/GovernorBravoDelegate.sol#L88