Platform: Code4rena
Start Date: 11/05/2022
Pot Size: $150,000 USDC
Total HM: 23
Participants: 93
Period: 14 days
Judge: LSDan
Total Solo HM: 18
Id: 123
League: ETH
Rank: 91/93
Findings: 1
Award: $83.25
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: IllIllI
Also found by: 0v3rf10w, 0x1f8b, 0x4non, 0xKitsune, 0xNazgul, 0xf15ers, 0xkatana, BowTiedWardens, CertoraInc, DavidGialdi, FSchmoede, Fitraldys, Funen, GimelSec, Hawkeye, JC, Kaiziron, Kthere, MaratCerby, MiloTruck, NoamYakov, QuantumBrief, Randyyy, Ruhum, SmartSek, SooYa, Tadashi, TerrierLover, Tomio, UnusualTurtle, WatchPug, Waze, _Adam, antonttc, asutorufos, bobirichman, c3phas, catchup, csanuragjain, cthulhu_cult, defsec, delfin454000, ellahi, fatherOfBlocks, hansfriese, hyh, jayjonah8, joestakey, kenta, marcopaladin, mics, minhquanym, orion, oyc_109, reassor, rfa, robee, sach1r0, samruna, sashik_eth, sikorico, simon135, unforgiven, z3s, zmj
83.2532 USDC - $83.25
remove usage of .add, .sub, .mul and .div Since the contract is written with solidity 0.8, there's no need to use SafeMath library for basic operation + - * /.
don't read user balance in AuraClaimZap if Option.UseAllWalletFunds is false.
In contract AuraClaimZap, it currently read crvBalance and cvxBalance first and pass it into _claimExtras. But it's not really used if Option.UseAllWalletFund is false.
uint256 crvBalance = IERC20(crv).balanceOf(msg.sender); uint256 cvxBalance = IERC20(cvx).balanceOf(msg.sender);
That being said, it would be better if the function don't read the balance if it won't be used in _claimExtras