Platform: Code4rena
Start Date: 31/03/2022
Pot Size: $75,000 USDC
Total HM: 7
Participants: 42
Period: 7 days
Judge: Jack the Pug
Total Solo HM: 5
Id: 102
League: ETH
Rank: 34/42
Findings: 1
Award: $125.78
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: rayn
Also found by: 0xDjango, 0xkatana, 0xkowloon, BouSalman, CertoraInc, Dravee, Funen, Hawkeye, IllIllI, Jujic, Kenshin, Kthere, Meta0xNull, Sleepy, TerrierLover, async, aysha, berndartmueller, catchup, cccz, cmichel, csanuragjain, danb, defsec, georgypetrov, hake, hubble, kenta, kyliek, pauliax, rfa, robee, sahar, shenwilly, teryanarmen
125.7841 USDC - $125.78
Immutable variable should use camelCase naming convention
Summary: Variable does not follow Solidity naming best pratices
Details: In RateLimited The variable MAX_RATE_LIMIT_PER_SECOND uses the all uppercase naming convention that is typically reserved for constant variables in Solidity.
Github Permalinks: code
Mitigation: Consider renaming MAX_RATE_LIMIT_PER_SECOND using camelCase
Event voltUpdate is not emited
Summary: The event voltUpdate in ICore is not used
Details: In Core the init function is used to update the volt address. It seems the intent of the developer may be to emit this as an event since the voltUpdate event exists in the Core interface ICore. Further, the setVcon function in Core emits the VconUpdate event when setVcon is called. Not emitting voltUpdate may be an oversight by the developer.
Github Permalinks: code
Mitigation: Emit voltUpdate in the init function or remove the unused event from ICore
#0 - ElliotFriedman
2022-04-07T17:09:04Z
MAX_RATE_LIMIT_PER_SECOND is immutable and will never change, therefore it should use the naming convention for constants.