Platform: Code4rena
Start Date: 31/03/2022
Pot Size: $75,000 USDC
Total HM: 7
Participants: 42
Period: 7 days
Judge: Jack the Pug
Total Solo HM: 5
Id: 102
League: ETH
Rank: 30/42
Findings: 1
Award: $125.78
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: rayn
Also found by: 0xDjango, 0xkatana, 0xkowloon, BouSalman, CertoraInc, Dravee, Funen, Hawkeye, IllIllI, Jujic, Kenshin, Kthere, Meta0xNull, Sleepy, TerrierLover, async, aysha, berndartmueller, catchup, cccz, cmichel, csanuragjain, danb, defsec, georgypetrov, hake, hubble, kenta, kyliek, pauliax, rfa, robee, sahar, shenwilly, teryanarmen
125.7841 USDC - $125.78
The overall quality of the Volt codebase is excellent. The modular architecture is very clear. Codes are very well documented, with additional explanatory comments when necessary. Tests are comprehensive and cover critical modules. Consider adding tests for external library functions such as BokkyPooBahsDateTimeContract.getDay().
CoreRef.
Governance can set a new vcon token address via Core.setVcon, while CoreRef._vcon can only be set once in the constructor. Therefore, setting a new vcon address will lead to inaccurate state in all contracts that inherit CoreRef. Consider adding a sync function to fetch the new vcon address from Core.