Abracadabra Mimswap - bareli's results

Lines of code

https://github.com/code-423n4/2024-03-abracadabra-money/blob/main/src/oracles/aggregators/MagicLpAggregator.sol#L33

Vulnerability details

Impact

Detailed description of the impact of this finding. Missing return statement in _getReserves: Function doesn't return the fetched reserves. We are not returning anything in _getReserves.It should return 2 unit246 integer but we are not returning anything.

we are calling this function in latestAnswer() for getting baseReserve and quoteReserve but we are not getting any output from _getReserves().

Proof of Concept

Provide direct links to all referenced code in GitHub. Add screenshots, logs, or any other relevant proof that illustrates the concept.

function _getReserves() internal view virtual returns (uint256, uint256) { (uint256 baseReserve, uint256 quoteReserve) = pair.getReserves(); }

function latestAnswer() public view override returns (int256) { uint256 baseAnswerNomalized = uint256(baseOracle.latestAnswer()) * (10 ** (WAD - baseOracle.decimals())); uint256 quoteAnswerNormalized = uint256(quoteOracle.latestAnswer()) * (10 ** (WAD - quoteOracle.decimals())); uint256 minAnswer = baseAnswerNomalized < quoteAnswerNormalized ? baseAnswerNomalized : quoteAnswerNormalized;

@>> (uint256 baseReserve, uint256 quoteReserve) = _getReserves();

Tools Used

Recommended Mitigation Steps

function _getReserves() internal view virtual returns (uint256, uint256) { (uint256 baseReserve, uint256 quoteReserve) = pair.getReserves(); ++ return(baseReserve,quoteReserve); }

Assessed type

Context

Missing License: The UNLICENSED SPDX identifier indicates the code is proprietary, which might not be intended. Version Lock: The pragma directive should lock the compiler to a specific version to prevent unexpected behavior from compiler updates.

pragma solidity >=0.8.0; https://github.com/code-423n4/2024-03-abracadabra-money/blob/main/src/blast/BlastDapp.sol#L2C1-L3C1