Foundation Drop contest - bin2chen's results

Low-1: 1.NFTDropCollection.sol reveal() can't change the baseURI after reveal(),recommended to check baseURI ! = _baseURI to avoid setting it to the old

  function reveal(string calldata _baseURI) external onlyAdmin validBaseURI(_baseURI) onlyWhileUnrevealed {
    // `postRevealBaseURIHash` == 0 indicates that the collection has been revealed.
    delete postRevealBaseURIHash;

    // Set the new base URI.
    ++++ require((keccak256(bytes(baseURI)) != keccak256(bytes(_baseURI))), "same");
    baseURI = _baseURI;
    emit URIUpdated(_baseURI, "");
  }

2.MarketFees.sol _distributeFunds() distribute the fund, relatively costly gas, but when the price is 0 is not necessary to distribute, it is recommended to return directly to save GAS

  function _distributeFunds(
    address nftContract,
    uint256 tokenId,
    address payable seller,
    uint256 price,
    address payable buyReferrer
  )
    internal
    returns (
      uint256 totalFees,
      uint256 creatorRev,
      uint256 sellerRev
    )
  {
    ++++ if (price == 0) {
    ++++  return (0,0,0);
    ++++ }

    ...

3.MarketFees.sol internalGetMutableRoyalties() determine the royaltyAmount>0 and then return, just like internalGetImmutableRoyalties().

  function internalGetMutableRoyalties(
    address nftContract,
    uint256 tokenId,
    address payable creator
  ) external view returns (address payable[] memory recipients, uint256[] memory splitPerRecipientInBasisPoints) {
     ....
     ...
        if (nftContract.supportsERC165InterfaceUnchecked(type(IRoyaltyInfo).interfaceId)) {
          try IRoyaltyInfo(nftContract).royaltyInfo{ gas: READ_ONLY_GAS_LIMIT }(tokenId, BASIS_POINTS) returns (
            address receiver,
         ----   uint256 /* royaltyAmount */
         ++++  uint256 royaltyAmount
          ) {
          ++++if (royaltyAmount) {
                recipients = new address payable[](1);
                recipients[0] = payable(receiver);
                splitPerRecipientInBasisPoints = new uint256[](1);
                // The split amount is assumed to be 100% when only 1 recipient is returned
                return (recipients, splitPerRecipientInBasisPoints);
          +++}