veRWA - ch0bu's results

Lines of code

https://github.com/code-423n4/2023-08-verwa/blob/main/src/GaugeController.sol#L69-L83 https://github.com/code-423n4/2023-08-verwa/blob/main/src/GaugeController.sol#L95-L109

Vulnerability details

Impact

If gas limit is reached transaction will revert

Proof of Concept

There are two for loops in GaugeController.sol contract that iterate 500 times, and since they are writing to a state variables there is a potential that they will reach gas limit and revert.

69	for (uint256 i; i < 500; ++i) {
70		if (t > block.timestamp) break;
71		t += WEEK;
72		uint256 d_bias = pt.slope * WEEK;
73		if (pt.bias > d_bias) {
74			pt.bias -= d_bias;
75			uint256 d_slope = changes_sum[t];
76			pt.slope -= d_slope;
77		} else {
78			pt.bias = 0;
79			pt.slope = 0;
80		}
81		points_sum[t] = pt;
82		if (t > block.timestamp) time_sum = t;
83	}

https://github.com/code-423n4/2023-08-verwa/blob/main/src/GaugeController.sol#L69-L83 https://github.com/code-423n4/2023-08-verwa/blob/main/src/GaugeController.sol#L95-L109

Tools Used

Manual review

Recommended Mitigation Steps

Reduce the number of iteration in loop, and iterate in batches.

Assessed type

Invalid Validation