veRWA - windhustler's results

VotingEscrow.sol

• LockAction.INCREASE_TIME and LockAction.QUIT are not used anywhere in the contract. They can be removed.

• _checkpoint function consider splitting the whole function into checkpoint individual and checkpoint global functions. This makes the code more readable and since the global state is not used anywhere except for the view functions it makes sense to split it.

• userOldPoint.slope and userNewPoint.slope calculations result in loss of precision. Consider multiplying the delegated amount with a multiplier(scaling before division) and using it as such through the codebase. And then dividing it back when needed to preserve accuracy. See Uniswap's approach.

• Remove redundant code Setting the userPointHistory[_addr][uEpoch + 1] twice is redundant since there is no else statement, the second assignment will always be executed.

• lastPoint can be written more concisely and save some gas as:

Point memory lastPoint;
if (epoch > 0) {
    lastPoint = pointHistory[epoch];
} else {
    lastPoint = Point({bias: 0, slope: 0, ts: block.timestamp, blk: block.number});
}

• Inconsistent styling through the codebase: In some places += is used, in other places plain + is used. Consider using the same style everywhere.

• Remove unnecessary nonReentrant function modifier from createLock, increaseAmount and delegate functions.

• Redundant sum after checking if locked_.amount == 0. Change to:

require(locked_.amount == 0, "Lock exists");
// Update lock and voting power (checkpoint)
locked_.amount = int128(int256(_value));

GaugeController.sol

• Consider tighter packing of VotedSlope struct.

struct VotedSlope {
        uint256 slope;
        uint240 end; // Max value is restricted by some time in the future so uint240 is enough.
        uint16 power; // Max value is 10000 so uint16 is enough.
    }

• Inline time_sum assignment:

time_sum = (block.timestamp / WEEK) * WEEK;

• Break at the bottom of the loop not to enter another iteration if the condition is met.

if (t > block.timestamp) {
    time_sum = t;
    break;
}

• Break at the bottom of the loop not to enter another iteration if the condition is met.

if (t > block.timestamp) {
    time_weight[_gauge_addr] = t;
    break;
}

• Early revert if the user's power used exceeds 100%. Consider placing this validation after fetching the old_slope for the msg.sender.