Platform: Code4rena
Start Date: 13/01/2023
Pot Size: $100,500 USDC
Total HM: 1
Participants: 23
Period: 10 days
Judge: hickuphh3
Total Solo HM: 1
Id: 201
League: ETH
Rank: 21/23
Findings: 1
Award: $140.67
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: horsefacts
Also found by: 0xSmartContract, ABA, Chom, IllIllI, Josiah, RaymondFam, Rickard, Rolezn, brgltd, btk, chaduke, charlesjhongc, csanuragjain, delfin454000, nadin, oyc_109
140.6728 USDC - $140.67
The amount of ERC721 transfer should be one. It's check in lib/Executor.sol(L348-L350) and lib/Executor.sol(L209-L211) but only in conduitKey == bytes32(0) cases. It should be checked whether via conduit or not. Otherwise it may cause failure when conduit execute it later.
Also, the related natspec description of _transferERC721() function doesn't seem correct. The amount must be 1 for ERC721, not identifier.
#0 - HickupHH3
2023-01-25T15:52:18Z
Regarding the check, I believe it's expected behaviour.
Agree with incorrect natspec description, which is a low issue. 1 low = 5 pts, just meeting cutoff.
#1 - c4-judge
2023-01-25T15:52:22Z
HickupHH3 marked the issue as grade-b