OpenSea Seaport 1.2 contest - delfin454000's results

Summary

Non-critical findings

OrderValidator.sol: L828-838

    function _getOrderStatus(
        bytes32 orderHash
    )
        internal
        view
        returns (
            bool isValidated,
            bool isCancelled,
            uint256 totalFilled,
            uint256 totalSize
        )

---

ConsiderationInterface: L107-458

is identical to

SeaportInterface: L106-457

---

Below is an example of the appropriate spacing of @dev statements used throughout the contest. @notice statements also normally have similar suitable spacing.

PointerLibraries.sol: L75-77

    /// @dev Resolves an offset stored at `cdPtr + headOffset` to a calldata.
    ///      pointer `cdPtr` must point to some parent object with a dynamic
    ///      type's head stored at `cdPtr + headOffset`.

On the other hand, as the examples below show, @param, @custom:param and @return statements tend to have extra-wide spacing when they wrap. This should be corrected.

---

Consideration.sol: L236-240

     * @custom:param considerationFulfillments An array of FulfillmentComponent
     *                                         arrays indicating which
     *                                         consideration items to attempt to
     *                                         aggregate when preparing
     *                                         executions.

---

Consideration.sol: L373-376

     * @param recipient                        The intended recipient for all
     *                                         received items, with `address(0)`
     *                                         indicating that the caller should
     *                                         receive the offer items.

---

ConsiderationDecoder.sol: L28-32

     * @param cdPtrLength A calldata pointer to the start of the bytes array in
     *                    calldata which contains the length of the array.
     *
     * @return mPtrLength A memory pointer to the start of the bytes array in
     *                    memory which contains the length of the array.

---

ConsiderationStructs.sol: L16-38

/**
 * @dev An order contains eleven components: an offerer, a zone (or account that
 *      can cancel the order or restrict who can fulfill the order depending on
 *      the type), the order type (specifying partial fill support as well as
 *      restricted order status), the start and end time, a hash that will be
 *      provided to the zone when validating restricted orders, a salt, a key
 *      corresponding to a given conduit, a counter, and an arbitrary number of
 *      offer items that can be spent along with consideration items that must
 *      be received by their respective recipient.
 */
struct OrderComponents {
    address offerer;
    address zone;
    OfferItem[] offer;
    ConsiderationItem[] consideration;
    OrderType orderType;
    uint256 startTime;
    uint256 endTime;
    bytes32 zoneHash;
    uint256 salt;
    bytes32 conduitKey;
    uint256 counter;
}

---

---

TypehashDirectory.sol: L31

        // Declare an array where each type hash will be writter.

Change writter to writer

---

ConsiderationEncoder.sol: L2

pragma solidity ^0.8.13;

---

---