FairSide contest - elprofesor's results

Handle

elprofesor

Vulnerability details

Impact

Strings are allocated space in storage slots at 32 bytes at a time. Excessive string lengths can cause unnecessary storage allocation which in turn costs gas.

Proof of Concept

Examples can be found throughout the code, however, notably Dao L427 uses the following require strings "FairSideDAO::propose: one live proposal per proposer, found an already active proposal". This string length totals 86 bytes which therefore takes 3 lots of 32 bytes. We believe this to be unnecessary, examples of smaller sized require reason strings could be: Dao: User has active proposal

Recommended Mitigation Steps

use shorter strings in require reasons where possible