FairSide contest - pants's results

Handle

pants

Vulnerability details

Vulnerability details

These files has open TODOs:

• ABC.sol
• FSDNetwork.sol

Impact

Open TODOs can hint at programming or architectural errors that still need to be fixed.

Tool Used

Manual code review.

Recommended Mitigation Steps

Resolve these TODOs and bubble up the errors.

Handle

pants

Vulnerability details

Shortening revert strings to fit in 32 bytes will decrease deployment time gas and will decrease runtime gas when the revert condition has been met.

For example line 146, 150 of FairSideConviction.sol

look at https://github.com/code-423n4/2021-09-sushimiso-findings/issues/134

Handle

pants

Vulnerability details

At FairSideDAO.sol lines 344, 508, 552 and TributeAccural.sol lines 83, 86 you use i++ instead of ++i to increase the loop index.

++i is more gas efficient and this improves every iteration and save gas. This is a relatively small and important change that we recommend to apply.

Handle

pants

Vulnerability details

At getActions - FairSideDAO.sol lines 272 you return using both named return and actual return statement. To save gas and improve code quality consider using only one of those.

function getActions(uint256 proposalId)
    public
    view
    returns (
        address[] memory targets,
        uint256[] memory values,
        string[] memory signatures,
        bytes[] memory calldatas
    )
{
    Proposal storage p = proposals[proposalId];
    return (p.targets, p.values, p.signatures, p.calldatas);
}

Handle

pants

Vulnerability details

The following functions could be set external instead of public to save gas. FairSideDao.sol function cancel FairSideDao.sol function execute FairSideDao.sol function queue Migrations.sol function setCompleted

external functions are cheaper than public functions.

Proof of Concept

https://gus-tavo-guim.medium.com/public-vs-external-functions-in-solidity-b46bcf0ba3ac

Tool Used

Manual code review.

Recommended Mitigation Steps

Define those functions as external.