Debt DAO contest - emrekocak's results

USE A MORE RECENT VERSION OF SOLIDITY

Use a solidity version of at least 0.8.10 to have external calls skip contract existence checks if the external call has a return value

Including all files in the scope.

REPLACE MODIFIER WITH FUNCTION

Modifiers make code more elegant, but cost more than normal functions.

Instances include: contracts/modules/credit/LineOfCredit.sol:78 contracts/modules/credit/LineOfCredit.sol:83 contracts/modules/credit/LineOfCredit.sol:88 contracts/modules/credit/LineOfCredit.sol:98 contracts/modules/interest-rate/InterestRateCredit.sol:25 contracts/utils/MutualConsent.sol:31

Always put your require statement on top in the function

Instances include: contracts/modules/credit/LineOfCredit.sol:259

Use assembly to check for address(0)

Saves 6 gas per instance if using assembly to check for address(0)
e.g.

assembly {  
 if iszero(_addr) {  
  mstore(0x00, "zero address")  
  revert(0x00, 0x20)  
 }  
}  

Instances include: contracts/modules/credit/LineOfCredit.sol:445 contracts/modules/factories/LineFactory.sol:27 contracts/modules/factories/LineFactory.sol:30 contracts/modules/factories/LineFactory.sol:33 contracts/modules/factories/LineFactory.sol:141 contracts/modules/factories/LineFactory.sol:146 contracts/utils/LineLib.sol:42 contracts/utils/LineLib.sol:67 contracts/utils/LineLib.sol:81 contracts/utils/SpigotLib.sol:189 contracts/utils/SpigotLib.sol:201

Use selfbalance()

Use selfbalance() instead of address(this).balance when getting your contract's balance of ETH to save gas. Instances include: contracts/utils/LineLib.sol:84