Debt DAO contest - seyni's results

QA

[L-01] Missing address(0) check in LineFactory constructor

LineFactory.sol#L20-L39

Change this:

    constructor(
        address moduleFactory,
        address arbiter_,
        address oracle_,
        address swapTarget_
    ) {
        factory = IModuleFactory(moduleFactory);
        if (arbiter_ == address(0)) {
            revert InvalidArbiterAddress();
        }
        if (oracle_ == address(0)) {
            revert InvalidOracleAddress();
        }
        if (swapTarget_ == address(0)) {
            revert InvalidSwapTargetAddress();
        }
        arbiter = arbiter_;
        oracle = oracle_;
        swapTarget = swapTarget_;
    }

To this:

    constructor(
        address moduleFactory_,
        address arbiter_,
        address oracle_,
        address swapTarget_
    ) {
        if (moduleFactory_ == address(0)) {
            revert InvalidModuleFactoryAddress();
        }
        if (arbiter_ == address(0)) {
            revert InvalidArbiterAddress();
        }
        if (oracle_ == address(0)) {
            revert InvalidOracleAddress();
        }
        if (swapTarget_ == address(0)) {
            revert InvalidSwapTargetAddress();
        }
        factory = IModuleFactory(moduleFactory_);
        arbiter = arbiter_;
        oracle = oracle_;
        swapTarget = swapTarget_;
    }

Gas optimizations

I only put the instances for which there wasn't a trade off between gas saving for deployment vs methods.

Optimizer settings:

optimizer = true
optimizer_runs = 200

[G-01] storage pointer to a structure is cheaper than copying each value of the structure into memory

For instance, change this:

          Credit memory credit = credits[id];

To this:

          Credit storage credit = credits[id];

---

LineOfCredit.sol#L205

          Credit memory credit = credits[id];

LineOfCredit.sol#L257

        Credit memory credit = credits[id];

---

InterestRateCredit.sol#L47

        Rate memory rate = rates[id];

---

EscrowLib.sol#L56

        IEscrow.Deposit memory d;

[G-02] State variables should be cached in stack variables rather than re-reading them from storage

InterestRateCredit.sol#L47-L50

Change this:

        Rate memory rate = rates[id];
        uint256 timespan = block.timestamp - rate.lastAccrued;
        // update last timestamp in storage
        rates[id].lastAccrued = block.timestamp;

To this (rate data location has been set to storage in [G-01]):

        Rate storage rate = rates[id];
        uint256 timespan = block.timestamp - rate.lastAccrued;
        // update last timestamp in storage
        rate.lastAccrued = block.timestamp;