Mimo August 2022 contest - erictee's results

[L-01] Unspecific Compiler Version Pragma

Impact

Avoid floating pragmas for non-library contracts.

While floating pragmas make sense for libraries to allow them to be included with multiple different versions of applications, it may be a security risk for application implementations.

A known vulnerable compiler version may accidentally be selected or security tools might fall-back to an older compiler version ending up checking a different EVM compilation that is ultimately deployed on the blockchain.

It is recommended to pin to a concrete compiler version.

Findings:

contracts/proxy/MIMOProxy.sol::2 => pragma solidity >=0.8.4;
contracts/proxy/MIMOProxyFactory.sol::2 => pragma solidity >=0.8.4;
contracts/proxy/MIMOProxyRegistry.sol::2 => pragma solidity >=0.8.4;
contracts/proxy/interfaces/IMIMOProxy.sol::2 => pragma solidity ^0.8.4;
contracts/proxy/interfaces/IMIMOProxyFactory.sol::2 => pragma solidity ^0.8.4;
contracts/proxy/interfaces/IMIMOProxyRegistry.sol::2 => pragma solidity ^0.8.4;

[L-02] Address checks should use && instead of || .

Impact

Should change || to && in order to ensure that all addresses are not zero.

Findings:

https://github.com/code-423n4/2022-08-mimo/blob/main/contracts/actions/MIMOSwap.sol#L27 https://github.com/code-423n4/2022-08-mimo/blob/main/contracts/actions/MIMOVaultActions.sol#L33

[L-03] Missing zero address checks when assigning values to address state variables.

Finding:

https://github.com/code-423n4/2022-08-mimo/blob/main/contracts/proxy/MIMOProxyFactory.sol#L26-L28