Sherlock contest - gzeon's results

Handle

gzeon

Vulnerability details

Impact

https://github.com/code-423n4/2022-01-sherlock/blob/c763f10c4b5fe2127677d6c25b83adcf3bcec212/contracts/interfaces/managers/ISherlockClaimManager.sol#L57

  struct Claim {
    uint256 created;
    uint256 updated;
    address initiator;
    bytes32 protocol;
    uint256 amount;
    address receiver;
    uint32 timestamp;
    State state;
    bytes ancillaryData;
  }

can be reordered to save 1 storage slot

  struct Claim {
    uint256 created;
    uint256 updated;
    uint256 amount;
    address initiator;
    bytes32 protocol;
    address receiver;
    uint32 timestamp;
    State state;
    bytes ancillaryData;
  }

Handle

gzeon

Vulnerability details

Impact

https://github.com/code-423n4/2022-01-sherlock/blob/c763f10c4b5fe2127677d6c25b83adcf3bcec212/contracts/managers/SherlockClaimManager.sol#L232

    if (claimCallbacks.length == MAX_CALLBACKS) revert InvalidState();
    // Checks to see if this callback contract already exists
    for (uint256 i; i < claimCallbacks.length; i++) {
      if (claimCallbacks[i] == _callback) revert InvalidArgument();
    }

to

    uint _len = claimCallbacks.length;
    if (_len == MAX_CALLBACKS) revert InvalidState();
    // Checks to see if this callback contract already exists
    for (uint256 i; i < _len; i++) {
      if (claimCallbacks[i] == _callback) revert InvalidArgument();
    }