Sherlock contest - saian's results

Handle

saian

Vulnerability details

Impact

Array length read in each iteration of the for loop consumes more gas, a local variable can be used to store the length and can be used in the comparison operation.

Proof of Concept

https://github.com/code-423n4/2022-01-sherlock/blob/c763f10c4b5fe2127677d6c25b83adcf3bcec212/contracts/managers/SherlockClaimManager.sol#L234

https://github.com/code-423n4/2022-01-sherlock/blob/c763f10c4b5fe2127677d6c25b83adcf3bcec212/contracts/managers/SherlockClaimManager.sol#L505

Tools Used

Manual Analysis

Recommended Mitigation Steps

Array length can be stored in a temporary variable and used in the comparison operations in the loop.