bunker.finance contest - hake's results

Lines of code

PriceOracleImplementation.sol#L29-L31

Vulnerability details

Impact

latestAnswer function is deprecated. This function does not revert if no answer has been reached but returns zero. There is no check for stale price and round completeness. Price can be stale and lead to wrong return value.

Proof of Concept

Chainlink API Reference

int256 usdcPrice = ChainlinkFeed(0x986b5E1e1755e3C2440e960477f25201B0a8bbD4).latestAnswer();
if (usdcPrice <= 0) {
    return 0;
}

Recommended Mitigation Steps

Use latestRoundData instead as well as performing more thorough check on return data. Secondly, update compiler version pragma solidity ^0.5.16 to latest compiler version for better compatibility with modern Chainlink methods.

(uint80 roundID, int256 price, , uint256 timeStamp, uint80 answeredInRound) = oracle.latestRoundData();
require(usdcPrice > 0, "...");
require(answeredInRound >= roundID, "...");
require(timeStamp != 0, "...");