Platform: Code4rena
Start Date: 03/05/2022
Pot Size: $50,000 USDC
Total HM: 4
Participants: 46
Period: 5 days
Judge: gzeon
Total Solo HM: 2
Id: 117
League: ETH
Rank: 12/46
Findings: 2
Award: $392.16
🌟 Selected for report: 0
🚀 Solo Findings: 0
In the function getUnderlyingPrice(), Chainlink's latestAnswer() is used and this function is deprecated and should not be used as this function returns 0 when there is no data rather than giving out error.
Precedent of this issue can be found in (https://github.com/code-423n4/2021-06-tracer-findings/issues/145)
Manual code review
Use latestRoundData instead.
#0 - bunkerfinance-dev
2022-05-09T18:19:53Z
Duplicate of #1
🌟 Selected for report: BowTiedWardens
Also found by: 0x1337, 0x1f8b, 0x4non, 0xDjango, David_, Funen, GimelSec, IllIllI, Picodes, TerrierLover, WatchPug, bobi, cryptphi, csanuragjain, delfin454000, dirk_y, ellahi, fatherOfBlocks, hyh, ilan, jayjonah8, kebabsec, leastwood, oyc_109, robee, samruna, simon135, sorrynotsorry, throttle
93.5794 USDC - $93.58
Typo (https://github.com/bunkerfinance/bunker-protocol/blob/752126094691e7457d08fc62a6a5006df59bd2fe/contracts/PriceOracleImplementation.sol#L34) "checck" should be "check"
Commented code that needs to be removed Remove these codes that are commented ( https://github.com/bunkerfinance/bunker-protocol/blob/main/contracts/Comptroller.sol#L240-242 https://github.com/bunkerfinance/bunker-protocol/blob/main/contracts/Comptroller.sol#L261-262 https://github.com/bunkerfinance/bunker-protocol/blob/main/contracts/Comptroller.sol#L470-472 https://github.com/bunkerfinance/bunker-protocol/blob/main/contracts/Comptroller.sol#L497-499)