Platform: Code4rena
Start Date: 15/06/2022
Pot Size: $35,000 USDC
Total HM: 1
Participants: 36
Period: 3 days
Judge: Jack the Pug
Total Solo HM: 1
Id: 137
League: ETH
Rank: 25/36
Findings: 1
Award: $81.82
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: 0xNazgul
Also found by: 0xDjango, 0xFar5eer, 0xf15ers, BowTiedWardens, Chom, Dravee, IllIllI, Meera, MiloTruck, PierrickGT, TerrierLover, _Adam, cccz, codexploder, cryptphi, delfin454000, fatherOfBlocks, hansfriese, joestakey, oyc_109, simon135
81.8216 USDC - $81.82
Constants should be defined rather than using magic numbers 2022-06-nested\contracts\NestedFactory.sol#L161 2022-06-nested\contracts\NestedFactory.sol#L169 2022-06-nested\contracts\NestedFactory.sol#L264 2022-06-nested\contracts\NestedFactory.sol#L378 2022-06-nested\contracts\NestedFactory.sol#L443 2022-06-nested\contracts\NestedFactory.sol#L629
Natspec incomplete 2022-06-nested\contracts\NestedFactory.sol#L114 @return
2022-06-nested\contracts\operators\Beefy\lp\BeefyZapBiswapLPVaultOperator.sol#L232 @return
2022-06-nested\contracts\operators\Beefy\lp\BeefyZapBiswapLPVaultOperator.sol#L264 @param reserveA @param reserveB @param router @return
2022-06-nested\contracts\operators\Beefy\lp\BeefyZapUniswapLPVaultOperator.sol#L263 @param reserveA @param reserveB @param router @return
Change "withdrawed" to "withdrew"
#0 - Yashiru
2022-06-24T13:16:04Z
Duplicated of #76 at 5. constants should be defined rather than using magic numbers
#1 - Yashiru
2022-06-24T14:18:42Z
Duplicated of #45 at Typos
#2 - obatirou
2022-06-24T16:00:09Z
https://github.com/code-423n4/2022-06-nested-findings/issues/84#issuecomment-1165712399